Fix crash in dns.lookup, ensure getaddrinfo() only returns IPv4-only or IPv6-only results when it should, normalize node:dns errors #12223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Electroid
reviewed
Jun 28, 2024
| @@ -271,6 +271,10 @@ pub fn normalizeDNSName(name: []const u8, backend: *GetAddrInfo.Backend) []const | |||
| } else if (strings.isIPV6Address(name)) { | |||
| backend.* = .system; | |||
| } | |||
| // getaddrinfo() is inconsistent with ares_getaddrinfo() when using localhost | |||
There was a problem hiding this comment.
This doesn't really explain anything, what exactly is inconsistent?
Jarred-Sumner
force-pushed
the
jarred/fix-getaddrinfo-crash
branch
from
b29adb8
to
c75d413
Compare
|
❌ @Jarred-Sumner, your commit has failing tests :( 🪟💻 5 failing tests Windows x64 baseline
🪟💻 4 failing tests Windows x64
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This does three things:
getaddrinfo()will now only return connectable addresses due to theENONAME,ENODATAas bothENOTFOUND.node-postgresandpostgrespackages #11205bun create elysia myapptakes a long time and then returnsconnection refused#7298 (may already have been fixed by happy eyeballs, but hard to tell)Duplicates:
Not as confident this fixes these, but there's a high chance it does:
How did you verify your code works?
Re-enabled some tests, but that crash in CI should be fixed