feat(node:util): support array type in format for the styleText util #13807
+82
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavi2410
changed the title
paperdave
approved these changes
Sep 10, 2024
|
implementation looks reasonable, but the test is failing.
|
|
I have now removed a useless test case that was not supposed to fail. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This adds support for format array type in the
styleTextfunction from thenode:utilmodule. This feature is already https://nodejs.org/api/util.html#utilstyletextformat-text-options in Node.jsHow did you verify your code works?
I wrote automated tests matching those from Node.js