-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
net compatibility improvements #14933
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ @cirospaciari, your commit dcf27fb has 3 failures in test/js/web/fetch/fetch-preconnect.test.ts - 1 failing on 🍎 aarch64test/regression/issue/ctrl-c.test.ts - 1 failing on 🍎 aarch64test/js/web/fetch/fetch.tls.test.ts - 1 failing on 🍎 aarch64 |
thank you :)
…On Fri, Nov 8, 2024 at 9:34 AM Jarred Sumner ***@***.***> wrote:
Merged #14933 <#14933> into main.
—
Reply to this email directly, view it on GitHub
<#14933 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/BDE7AAFLYMBM22FW2HNWAX3Z7RIAXAVCNFSM6AAAAABQ7L725GVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJVGIYDIMJRGQYDMOI>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix: #13217
CheckList:
Note: not all options in listen and connect are handled today.
Class: net.BlockList
Class: net.SocketAddress
Class: net.Server
Class: net.Socket
Module:
How did you verify your code works?