Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(socket) Support named pipes on Windows using forward slashes #15112

Merged
merged 3 commits into from
Nov 13, 2024
Merged

fix(socket) Support named pipes on Windows using forward slashes #15112

merged 3 commits into from
Nov 13, 2024

Conversation

cirospaciari
Copy link
Member

What does this PR do?

Fix: #14329

  • Documentation or TypeScript types (it's okay to leave the rest blank in this case)
  • Code changes

How did you verify your code works?

Test

@robobun
Copy link

robobun commented Nov 12, 2024 •
edited
Loading

❌ @cirospaciari, your commit 74e2567 has 5 failures in #5933:

  • test/js/web/fetch/fetch.tls.test.ts - 1 failing on 🍎 aarch64
  • test/regression/issue/ctrl-c.test.ts - 1 failing on 🍎 aarch64
  • test/js/node/test/parallel/child-process-exec-timeout-kill.test.js - 1 failing on 🍎 aarch64
  • test/cli/run/require-cache.test.ts - 1 failing on 🪟 x64-baseline
  • test/cli/install/bunx.test.ts - 1 failing on 🪟 x64-baseline
    		•

    @cirospaciari cirospaciari requested review from a team and paperdave and removed request for a team November 12, 2024 20:38
    paperdave
    paperdave reviewed Nov 12, 2024
    View reviewed changes
    Copy link
    Member

    @paperdave paperdave left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    is \/.\pipe/ supposed to work (mixing slashes in the string)

    @cirospaciari cirospaciari force-pushed the ciro/fix-pipe-name0check branch from 4e8b170 to 4e59fd0 Compare November 12, 2024 22:40
    paperdave
    paperdave approved these changes Nov 12, 2024
    View reviewed changes
    Copy link
    Member

    @paperdave paperdave left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    damn the nesting on isValidPipeName

    @Jarred-Sumner Jarred-Sumner merged commit 873b0a7 into main Nov 13, 2024
    22 of 25 checks passed
    @Jarred-Sumner Jarred-Sumner deleted the ciro/fix-pipe-name0check branch November 13, 2024 00:09
    snoglobe pushed a commit that referenced this pull request Nov 18, 2024
    @cirospaciari @snoglobe
    fix(socket) Support named pipes on Windows using forward slashes (#15112
    927e0da 
    )
    snoglobe pushed a commit that referenced this pull request Nov 21, 2024
    @cirospaciari @snoglobe
    fix(socket) Support named pipes on Windows using forward slashes (#15112
    c503caa 
    )
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @paperdave paperdave paperdave approved these changes

    Assignees
    No one assigned
    Labels
    None yet
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.

    Support named pipes on Windows using forward slashes
    4 participants
    @cirospaciari @robobun @paperdave @Jarred-Sumner