Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

attempt to fix debugger #15788

Merged
merged 7 commits into from
Dec 17, 2024
Merged

attempt to fix debugger #15788

merged 7 commits into from
Dec 17, 2024

Conversation

RiskyMH
Copy link
Member

@RiskyMH RiskyMH commented Dec 16, 2024

2 different fixes:

  1. make vscode debugger work by removing BUN_INSPECT_CONNECT_TO condition to not wait forever (as extension always sets it, bun doesnt wait enough usually)
  2. reverts some changes in BunDebugger.cpp so it works in debug.bun.sh again (it seems to still work for vscode)

fixes #15439
fixes maybe #15715

RiskyMH and others added 4 commits December 16, 2024 09:58
it was added for vscode extention issue, but that is older now and it breaks the actual debugger by not having to wait enough
@RiskyMH RiskyMH marked this pull request as ready for review December 16, 2024 09:40
@Jarred-Sumner
Copy link
Collaborator

The second thing that defaults it to .shortly should be reverted. We can remove the commented out code though

@Jarred-Sumner Jarred-Sumner merged commit 67e4aec into main Dec 17, 2024
67 checks passed
@Jarred-Sumner Jarred-Sumner deleted the riskymh/debugger-maybefix branch December 17, 2024 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Debugging Not Working After Upgrade to 1.1.37
3 participants