Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pass all upstream node:os tests, all supported node:async_hooks tests #15802

Merged
merged 12 commits into from
Dec 17, 2024

Conversation

paperdave
Copy link
Member

@paperdave paperdave commented Dec 17, 2024

New Node.js test passing:

  • node:os: pass all of them
  • node:async_hooks i do not intend to support createHook or async_wrap, however i will support AsyncLocalStorage and AsyncResource. we pass all of these tests.

In addition,

  • bindgen gets validateInteger and validateInt32
  • after being bit by a manual c-translation mistake, i've added src/c-headers-for-zig.h, which is run through translate-c and exposed under bun.C.translated. We should move most of our manual definitions to this process eventually (all calls into documented libc, documented windows APIs, all dependencies, and maybe eventually all our own C++ headers)

@paperdave paperdave requested review from a team and dylan-conway and removed request for a team December 17, 2024 00:36
@paperdave paperdave changed the title pass all upstream node:os tests pass all upstream node:os tests, all supported node:async_hooks tests Dec 17, 2024
@@ -3993,7 +3993,7 @@ pub const VirtualMachine = struct {

if (show.system_code) {
if (show.syscall) {
try writer.writeAll(" ");
try writer.writeAll(" ");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this supposed to be two spaces? and do we also need to print spaces before syscall in if (show.syscall)?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it printed with one less in the situation i tried. maybe this whole logic should be redone to just compute the indent level of the : and then be able to compute the # of spaces per line.

@paperdave paperdave merged commit 77acfa2 into main Dec 17, 2024
67 checks passed
@paperdave paperdave deleted the dave/node-os branch December 17, 2024 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants