-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pass all upstream node:os tests, all supported node:async_hooks tests #15802
Conversation
Updated 10:20 PM PT - Dec 16th, 2024
❌ @paperdave, your commit c043189 has 7 failures in
🧪 try this PR locally: bunx bun-pr 15802 |
@@ -3993,7 +3993,7 @@ pub const VirtualMachine = struct { | |||
|
|||
if (show.system_code) { | |||
if (show.syscall) { | |||
try writer.writeAll(" "); | |||
try writer.writeAll(" "); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this supposed to be two spaces? and do we also need to print spaces before syscall
in if (show.syscall)
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it printed with one less in the situation i tried. maybe this whole logic should be redone to just compute the indent level of the : and then be able to compute the # of spaces per line.
New Node.js test passing:
node:os
: pass all of themnode:async_hooks
i do not intend to support createHook or async_wrap, however i will support AsyncLocalStorage and AsyncResource. we pass all of these tests.In addition,
validateInteger
andvalidateInt32