Include array length and promise status in V8 heap snapshots (oven-sh/WebKit#75) #16141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Updated 3:22 PM PT - Jan 3rd, 2025
❌ @190n, your commit 878978c has 1 failures in
🧪 try this PR locally: bunx bun-pr 16141 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
When viewing a V8 heap snapshot generated by Bun, arrays now have
Array (length)[]in the description. Promises havePromise (pending),Promise (rejected),Promise (fulfilled), orPromise (fulfilled: value)if the value is a JSCell and we weren't already inside a promise.These changes were done in our WebKit fork, I'm just bumping the commit so they are included in Bun.
How did you verify your code works?
Tested the WebKit changes locally. Should ensure that the heap snapshot tests still pass in CI.