Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bunx command for github package #5974 #6042

Merged
merged 9 commits into from
Oct 3, 2023

Conversation

axlEscalada
Copy link
Contributor

What does this PR do?

Fix the bunx command when a github repo is passed as an argument. There is a bug where the package name is parsed as an UpdateRequest that leaves the name of the package empty and fails when trying to concatenate name + @ + version
In bunx_command name and version are checked and if they are equal set the name as the package name, and format it without @. Also this fmt package is used to build the path where is installed.

Fixes: #5974

  • Documentation or TypeScript types (it's okay to leave the rest blank in this case)
  • Code changes

How did you verify your code works?

  • I checked the lifetime of memory allocated to verify it's (1) freed and (2) only freed when it should be
  • I or my editor ran zig fmt on the changed files
  • I included a test for the new code, or an existing test covers it
  • JSValue used outside outside of the stack is either wrapped in a JSC.Strong or is JSValueProtect'ed

@Jarred-Sumner
Copy link
Collaborator

Thank you for this. One nitpicky comment

@Electroid
Copy link
Contributor

Tested and good-to-go. Thanks!

@Electroid Electroid merged commit 0ca9a78 into oven-sh:main Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bunx does not work with github:user/repo syntax
3 participants