Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix query property of url object #6274

Merged
merged 1 commit into from
Oct 5, 2023
Merged

Conversation

Jarred-Sumner
Copy link
Collaborator

What does this PR do?

parseUrl(url).query is supposed to be an object and not a URLSearchParams

How did you verify your code works?

I didn't, this needs a test

@github-actions
Copy link
Contributor

github-actions bot commented Oct 3, 2023

@Jarred-Sumner prettier reported errors

[warn] test/cli/install/bunx.test.ts
[warn] Code style issues found in the above file. Forgot to run Prettier?
error: "prettier" exited with code 1 (SIGHUP)
Checking formatting...

To one-off fix this manually, run:

bun fmt

You might need to run bun install locally and configure your text editor to auto-format on save.

#7d6d4ee1d040b3587d2207ab679c017ad5017d7e

@github-actions
Copy link
Contributor

github-actions bot commented Oct 3, 2023

@Jarred-Sumner 5 files with test failures on linux-x64:

  • test/cli/install/bun-install.test.ts
  • test/js/node/watch/fs.watch.test.ts
  • test/js/third_party/mongodb/mongodb.test.ts
  • test/js/third_party/postgres/postgres.test.ts
  • test/js/third_party/prisma/prisma.test.ts

View test output

#7d6d4ee1d040b3587d2207ab679c017ad5017d7e

@github-actions
Copy link
Contributor

github-actions bot commented Oct 3, 2023

@Jarred-Sumner 5 files with test failures on linux-x64-baseline:

  • test/cli/install/bun-install.test.ts
  • test/js/node/watch/fs.watch.test.ts
  • test/js/third_party/mongodb/mongodb.test.ts
  • test/js/third_party/postgres/postgres.test.ts
  • test/js/third_party/prisma/prisma.test.ts

View test output

#7d6d4ee1d040b3587d2207ab679c017ad5017d7e

@github-actions
Copy link
Contributor

github-actions bot commented Oct 3, 2023

@Jarred-Sumner 9 files with test failures on bun-darwin-aarch64:

  • test/cli/install/bun-install.test.ts
  • test/integration/next/default-pages-dir/test/dev-server.test.ts
  • test/js/bun/spawn/spawn.test.ts
  • test/js/bun/test/test-test.test.ts
  • test/js/bun/util/filesink.test.ts
  • test/js/node/watch/fs.watch.test.ts
  • test/js/third_party/mongodb/mongodb.test.ts
  • test/js/third_party/postgres/postgres.test.ts
  • test/js/third_party/prisma/prisma.test.ts

View test output

#7d6d4ee1d040b3587d2207ab679c017ad5017d7e

@github-actions
Copy link
Contributor

github-actions bot commented Oct 3, 2023

@Jarred-Sumner 11 files with test failures on bun-darwin-x64-baseline:

  • test/cli/install/bun-install.test.ts
  • test/js/bun/spawn/spawn-streaming-stdout.test.ts
  • test/js/bun/spawn/spawn.test.ts
  • test/js/bun/util/filesink.test.ts
  • test/js/node/fs/fs.test.ts
  • test/js/node/os/os.test.js
  • test/js/third_party/mongodb/mongodb.test.ts
  • test/js/third_party/postgres/postgres.test.ts
  • test/js/third_party/prisma/prisma.test.ts
  • test/js/third_party/webpack/webpack.test.ts
  • test/js/web/timers/setTimeout.test.js

View test output

#7d6d4ee1d040b3587d2207ab679c017ad5017d7e

@Jarred-Sumner Jarred-Sumner merged commit 5c82335 into main Oct 5, 2023
13 of 19 checks passed
@Jarred-Sumner Jarred-Sumner deleted the jarred/fix-query-url branch October 5, 2023 04:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant