Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Node.js compat docs #6282

Merged
merged 3 commits into from
Oct 5, 2023
Merged

Update Node.js compat docs #6282

merged 3 commits into from
Oct 5, 2023

Conversation

colinhacks
Copy link
Contributor

What does this PR do?

  • Documentation or TypeScript types (it's okay to leave the rest blank in this case)
  • Code changes

How did you verify your code works?

@paperdave
Copy link
Collaborator

node:module is missing a ton of stuff too. maybe it should also be clarified that monkey-patching that module may not work.

for events, addAbortListener was added in v20. i think we should keep a better eye on new Node.js APIs, and also put the version of node that this page is for.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2023

@colinhacks 10 files with test failures on bun-darwin-aarch64:

  • test/bundler/bundler_edgecase.test.ts
  • test/cli/install/bun-install.test.ts
  • test/integration/next/default-pages-dir/test/dev-server.test.ts
  • test/js/bun/test/test-test.test.ts
  • test/js/bun/util/filesink.test.ts
  • test/js/bun/util/which.test.ts
  • test/js/node/watch/fs.watch.test.ts
  • test/js/third_party/mongodb/mongodb.test.ts
  • test/js/third_party/postgres/postgres.test.ts
  • test/js/web/worker.test.ts

View test output

#3d4aba8a4b74dc028698237e7b10a3fc483ab61d

@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2023

@colinhacks 5 files with test failures on linux-x64-baseline:

  • test/cli/install/bun-install.test.ts
  • test/js/node/watch/fs.watch.test.ts
  • test/js/third_party/mongodb/mongodb.test.ts
  • test/js/third_party/postgres/postgres.test.ts
  • test/js/third_party/prisma/prisma.test.ts

View test output

#3d4aba8a4b74dc028698237e7b10a3fc483ab61d

@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2023

@colinhacks 8 files with test failures on linux-x64:

  • test/bundler/esbuild/splitting.test.ts
  • test/cli/install/bun-install.test.ts
  • test/integration/next/default-pages-dir/test/dev-server.test.ts
  • test/js/bun/util/filesink.test.ts
  • test/js/node/watch/fs.watch.test.ts
  • test/js/third_party/mongodb/mongodb.test.ts
  • test/js/third_party/postgres/postgres.test.ts
  • test/js/third_party/prisma/prisma.test.ts

View test output

#3d4aba8a4b74dc028698237e7b10a3fc483ab61d

@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2023

@colinhacks 9 files with test failures on bun-darwin-x64-baseline:

  • test/cli/install/bun-install.test.ts
  • test/js/bun/util/filesink.test.ts
  • test/js/node/fs/fs.test.ts
  • test/js/node/watch/fs.watchFile.test.ts
  • test/js/third_party/mongodb/mongodb.test.ts
  • test/js/third_party/postgres/postgres.test.ts
  • test/js/third_party/prisma/prisma.test.ts
  • test/js/third_party/webpack/webpack.test.ts
  • test/js/web/timers/setTimeout.test.js

View test output

#3d4aba8a4b74dc028698237e7b10a3fc483ab61d

@colinhacks colinhacks merged commit 323ae0f into main Oct 5, 2023
11 checks passed
@colinhacks colinhacks deleted the nodejs-compat branch October 5, 2023 23:03
@@ -74,11 +76,11 @@ This page is updated regularly to reflect compatibility status of the latest ver

### [`node:module`](https://nodejs.org/api/module.html)

🟢 Fully implemented.
🟢 Missing `runMain` `syncBuiltinESMExports`, `Module#load()`. Attempts to override or patch the module cache will fail.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This circle should be Yellow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants