feat(test): implement toEqualIgnoringWhitespace
#6293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dylan-conway
reviewed
Oct 5, 2023
| const value: JSValue = this.getValue(globalThis, thisValue, "toEqualIgnoringWhitespace", "<green>expected<r>") orelse return .zero; | ||
|
|
||
| const not = this.flags.not; | ||
| var pass = value.isString() and expected.isString(); |
There was a problem hiding this comment.
does expect({}).not.toEqualIgnoringWhitespace({}) pass in jest extended? We might need to throw an error for unexpected arg types
dylan-conway
reviewed
Oct 5, 2023
src/bun.js/test/expect.zig
Outdated
| var valueStr = value.toString(globalThis).toSlice(globalThis, default_allocator).slice(); | ||
|
|
||
| // Remove all whitespace from both strings | ||
| expectedStr = strings.removeWhitespace(default_allocator, expectedStr); |
There was a problem hiding this comment.
Could you change this to compare the original strings, skipping all whitespace characters in the comparison? This way we don't need to allocate more memory
EladBezalel
force-pushed
the
feat/toEqualIgnoringWhitespace
branch
from
fcadc5c
to
2f90f9a
Compare
|
Thank you |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
toEqualIgnoringWhitespaceto bun test utilsstrings.removeWhitespaceto zig strings utilsHow did you verify your code works?
expect.test.js&jest-extended.test.jsmake codegento regenerate the C++ and Zig coderelated to #1825