Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #6309 #6310

Merged
merged 1 commit into from
Oct 5, 2023
Merged

Closes #6309 #6310

merged 1 commit into from
Oct 5, 2023

Conversation

colinhacks
Copy link
Contributor

@colinhacks colinhacks commented Oct 5, 2023

#6309

Perhaps the root of the problem is that this[kInternalSocketData] should be set at this point..? This just uses optional chaining through the whole expression make this more crash-resistant anyway.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2023

@colinhacks 9 files with test failures on bun-darwin-aarch64:

  • test/cli/install/bun-install.test.ts
  • test/integration/next/default-pages-dir/test/dev-server.test.ts
  • test/js/bun/spawn/spawn.test.ts
  • test/js/bun/test/test-test.test.ts
  • test/js/bun/util/filesink.test.ts
  • test/js/node/watch/fs.watch.test.ts
  • test/js/third_party/mongodb/mongodb.test.ts
  • test/js/third_party/postgres/postgres.test.ts
  • test/js/third_party/prisma/prisma.test.ts

View test output

#41d9010a8aceb151ebcff63ec9743cbf2892b215

@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2023

@colinhacks 6 files with test failures on linux-x64-baseline:

  • test/cli/install/bun-install.test.ts
  • test/js/node/watch/fs.watch.test.ts
  • test/js/third_party/mongodb/mongodb.test.ts
  • test/js/third_party/postgres/postgres.test.ts
  • test/js/third_party/prisma/prisma.test.ts
  • test/js/web/fetch/fetch-gzip.test.ts

View test output

#41d9010a8aceb151ebcff63ec9743cbf2892b215

@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2023

@colinhacks 7 files with test failures on linux-x64:

  • test/cli/install/bun-install.test.ts
  • test/js/bun/util/filesink.test.ts
  • test/js/node/watch/fs.watch.test.ts
  • test/js/third_party/mongodb/mongodb.test.ts
  • test/js/third_party/postgres/postgres.test.ts
  • test/js/third_party/prisma/prisma.test.ts
  • test/js/web/fetch/fetch-gzip.test.ts

View test output

#41d9010a8aceb151ebcff63ec9743cbf2892b215

@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2023

@colinhacks 13 files with test failures on bun-darwin-x64-baseline:

  • test/cli/install/bun-install.test.ts
  • test/js/bun/spawn/spawn-streaming-stdout.test.ts
  • test/js/bun/spawn/spawn.test.ts
  • test/js/node/fs/fs.test.ts
  • test/js/node/os/os.test.js
  • test/js/node/watch/fs.watchFile.test.ts
  • test/js/third_party/mongodb/mongodb.test.ts
  • test/js/third_party/postgres/postgres.test.ts
  • test/js/third_party/prisma/prisma.test.ts
  • test/js/third_party/socket.io/socket.io-connection-state-recovery.test.ts
  • test/js/third_party/webpack/webpack.test.ts
  • test/js/web/timers/setInterval.test.js
  • test/js/web/timers/setTimeout.test.js

View test output

#41d9010a8aceb151ebcff63ec9743cbf2892b215

@Jarred-Sumner Jarred-Sumner merged commit 5da79a8 into main Oct 5, 2023
14 of 19 checks passed
@Jarred-Sumner Jarred-Sumner deleted the colinhacks/close-6309 branch October 5, 2023 04:28
@Jarred-Sumner
Copy link
Collaborator

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants