-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix memory leak in fetch() #6350
Conversation
❌ @Jarred-Sumner [warn] test/cli/install/bun-install.test.ts
[warn] Code style issues found in the above file. Forgot to run Prettier?
error: "prettier" exited with code 1 (SIGHUP)
Checking formatting... To one-off fix this manually, run: bun fmt You might need to run |
❌ @Jarred-Sumner 5 files with test failures on linux-x64-baseline:
|
❌ @Jarred-Sumner 6 files with test failures on linux-x64:
|
❌ @Jarred-Sumner 10 files with test failures on bun-darwin-aarch64:
|
❌ @Jarred-Sumner 10 files with test failures on bun-darwin-x64-baseline:
|
This is amazing. As someone who is using Bun to run a long-running process in production, this is really needed. Props to the team 💯 |
good. |
What does this PR do?
We were not calling inflateEnd, which caused fetch() requests with gzip/deflate to leak memory
How did you verify your code works?
Memory usage is more stable now