Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: form data content type #6380

Merged
merged 2 commits into from
Oct 11, 2023
Merged

fix: form data content type #6380

merged 2 commits into from
Oct 11, 2023

Conversation

yadav-saurabh
Copy link
Contributor

@yadav-saurabh yadav-saurabh commented Oct 9, 2023 •
edited
Loading

fix for #6012

std.fs.path.extension(filename_str); 
// return extension name with a dot(.) the ex: somefile.pdf -> .pdf

bun.HTTP.MimeType.byExtensionNoDefault()
// expects extension name without any dot(.)

verified the code runs on my local build

image

Jarred-Sumner
Jarred-Sumner approved these changes Oct 10, 2023
View reviewed changes
Copy link
Collaborator

@Jarred-Sumner Jarred-Sumner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Jarred-Sumner Jarred-Sumner merged commit 9a90d90 into oven-sh:main Oct 11, 2023
15 of 20 checks passed
@Jarred-Sumner
Copy link
Collaborator

Thank you

@yadav-saurabh yadav-saurabh deleted the fix-form-data-type branch October 13, 2023 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jarred-Sumner Jarred-Sumner Jarred-Sumner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yadav-saurabh @Jarred-Sumner