fix(AbortSignal/fetch) fix AbortSignal.timeout, fetch lock behavior and fetch errors #6390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cirospaciari
force-pushed
the
ciro/abort-signal-timeout-fix
branch
from
c8c8ad6
to
d9f12a2
Compare
| struct us_internal_callback_t *internal_cb = (struct us_internal_callback_t *) timer; | ||
|
|
||
| struct kevent64_s event; | ||
| EV_SET64(&event, (uint64_t) (void*) internal_cb, EVFILT_TIMER, EV_DELETE, 0, 0, (uint64_t)internal_cb, 0, 0); | ||
| kevent64(internal_cb->loop->fd, &event, 1, NULL, 0, 0, NULL); | ||
|
|
||
| /* (regular) sockets are the only polls which are not freed immediately */ | ||
| us_poll_free((struct us_poll_t *) timer, internal_cb->loop); | ||
| if(fallthrough){ | ||
| us_free(timer); |
There was a problem hiding this comment.
isn't there a scenario where:
- Timer is scheduled to run in the next tick
- Tick happens, but before timer happens, the timer is cancelled
- Timer is freed
- Callback for timer runs after the timer is freed, which becomes a use-after-free
There was a problem hiding this comment.
today we call us_poll_free with just do:
void us_poll_free(struct us_poll_t *p, struct us_loop_t *loop) {
loop->num_polls--;
us_free(p);
}so is safe to assume that we are not breaking any behavior only avoiding loop->num_polls--; because on fallthrough: true we dont increment num_pools, But will check this scenario.
|
❌ @cirospaciari 7 files with test failures on bun-darwin-aarch64:
|
|
❌ @cirospaciari 6 files with test failures on linux-x64-baseline:
|
|
❌ @cirospaciari 5 files with test failures on linux-x64:
|
|
❌ @cirospaciari 10 files with test failures on bun-darwin-x64-baseline:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This fix fetch behavior on error cases, fix HTTP destroying too early causing missing parts/events not to be emitted, fix AbortSignal.timeout, fix proper closing/ending off fetch when aborted, and also fix the state of readable streams to be used not only empty.
Fix #6366
How did you verify your code works?
I wrote automated tests