Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make peer dependencies install by default #6396

Merged
merged 9 commits into from
Oct 11, 2023

Conversation

dylan-conway
Copy link
Collaborator

What does this PR do?

makes install.peer default to true in bunfig.toml. also makes installing peer dependencies work

fixes #5567
closes #5565
fixes #5209
fixes #5128
fixes #4472
fixes #3410

  • Documentation or TypeScript types (it's okay to leave the rest blank in this case)
  • Code changes

How did you verify your code works?

added tests

@github-actions
Copy link
Contributor

github-actions bot commented Oct 10, 2023

@dylan-conway 10 files with test failures on bun-darwin-aarch64:

  • test/bundler/bundler_edgecase.test.ts
  • test/cli/install/bun-install.test.ts
  • test/integration/next/default-pages-dir/test/dev-server.test.ts
  • test/js/bun/spawn/spawn.test.ts
  • test/js/bun/test/test-test.test.ts
  • test/js/bun/util/filesink.test.ts
  • test/js/node/watch/fs.watch.test.ts
  • test/js/third_party/postgres/postgres.test.ts
  • test/js/third_party/prisma/prisma.test.ts
  • test/js/web/fetch/body-stream.test.ts

View test output

#ce7b54405cc8f60260c893c6a71871b87110cdbd

@github-actions
Copy link
Contributor

github-actions bot commented Oct 10, 2023

@dylan-conway 5 files with test failures on linux-x64:

  • test/cli/install/bun-install.test.ts
  • test/js/bun/util/filesink.test.ts
  • test/js/node/watch/fs.watch.test.ts
  • test/js/third_party/postgres/postgres.test.ts
  • test/js/third_party/prisma/prisma.test.ts

View test output

#ce7b54405cc8f60260c893c6a71871b87110cdbd

@github-actions
Copy link
Contributor

github-actions bot commented Oct 10, 2023

@dylan-conway 5 files with test failures on linux-x64-baseline:

  • test/bundler/bun-build-api.test.ts
  • test/cli/install/bun-install.test.ts
  • test/js/node/watch/fs.watch.test.ts
  • test/js/third_party/postgres/postgres.test.ts
  • test/js/third_party/prisma/prisma.test.ts

View test output

#ce7b54405cc8f60260c893c6a71871b87110cdbd

@github-actions
Copy link
Contributor

github-actions bot commented Oct 10, 2023

@dylan-conway 9 files with test failures on bun-darwin-x64-baseline:

  • test/cli/install/bun-install.test.ts
  • test/js/bun/spawn/spawn-streaming-stdout.test.ts
  • test/js/bun/spawn/spawn.test.ts
  • test/js/bun/util/filesink.test.ts
  • test/js/node/fs/fs.test.ts
  • test/js/third_party/postgres/postgres.test.ts
  • test/js/third_party/prisma/prisma.test.ts
  • test/js/third_party/webpack/webpack.test.ts
  • test/js/web/timers/setTimeout.test.js

View test output

#ce7b54405cc8f60260c893c6a71871b87110cdbd

@Jarred-Sumner Jarred-Sumner merged commit 05781dd into main Oct 11, 2023
15 of 20 checks passed
@Jarred-Sumner Jarred-Sumner deleted the dylan/install-peer-dependencies branch October 11, 2023 03:06
@ghiscoding ghiscoding mentioned this pull request Oct 16, 2023
@gonzaloriestra
Copy link

The documentation still says that peer dependencies are not installed by default:

Is it outdated?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment