Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Response): single Content-Range in http response #7199

Merged
merged 3 commits into from
Nov 25, 2023

Conversation

WingLim
Copy link
Contributor

@WingLim WingLim commented Nov 18, 2023

What does this PR do?

Fix #7051

  • Documentation or TypeScript types (it's okay to leave the rest blank in this case)
  • Code changes

How did you verify your code works?

  • Add test

If user set header by himself, then we not write duplicate header.
Copy link
Collaborator

@Jarred-Sumner Jarred-Sumner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. This looks good, lets merge assuming the relevant tests pass

@Jarred-Sumner Jarred-Sumner merged commit 3d58437 into oven-sh:main Nov 25, 2023
18 of 28 checks passed
cirospaciari pushed a commit that referenced this pull request Nov 27, 2023
* fix: only write header if not exist

If user set header by himself, then we not write duplicate header.

* feat: add test to check header

* chore: format code
ryoppippi pushed a commit to ryoppippi/bun that referenced this pull request Feb 1, 2024
* fix: only write header if not exist

If user set header by himself, then we not write duplicate header.

* feat: add test to check header

* chore: format code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Duplicate header "Content-Range" in Response (cannot play html video)
2 participants