Delete bun_dev_http_server.zig
#7283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jarred-Sumner
commented
Nov 23, 2023
| @@ -3138,16 +3138,19 @@ fn handleResponseBodyChunkedEncodingFromMultiplePackets( | |||
| buffer.list.items.ptr + (buffer.list.items.len -| incoming_data.len), | |||
| &bytes_decoded, | |||
| ); | |||
| if (comptime Environment.allow_assert) { | |||
|
❌ @Jarred-Sumner 3 files with test failures on bun-darwin-aarch64:
|
|
❌ @Jarred-Sumner 1 files with test failures on linux-x64-baseline:
|
|
❌ @Jarred-Sumner 5 files with test failures on bun-darwin-x64-baseline:
|
cirospaciari
pushed a commit
that referenced
this pull request
Nov 27, 2023
ryoppippi
pushed a commit
to ryoppippi/bun
that referenced
this pull request
Feb 1, 2024
* Rename http_client_async -> http * Delete bun_dev_http_server.zig * update these * [uws] Add method for getting SO_ERROR --------- Co-authored-by: Jarred Sumner <709451+Jarred-Sumner@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
We removed
bun dev, but we left a lot of the code in there. This deletes more of it.How did you verify your code works?
It compiled