Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(node:fs): fix fs.promises.opendir not having a path property #7292

Merged
merged 1 commit into from
Nov 25, 2023
Merged

fix(node:fs): fix fs.promises.opendir not having a path property #7292

merged 1 commit into from
Nov 25, 2023

Conversation

samfundev
Copy link
Contributor

What does this PR do?

Adds the path property to the Dir class returned by fs.promises.opendir. Closes #4995

  • Documentation or TypeScript types (it's okay to leave the rest blank in this case)
  • Code changes

How did you verify your code works?

  • I included a test for the new code, or existing tests cover it
  • I ran my tests locally and they pass (bun-debug test test-file-name.test)

paperdave
paperdave approved these changes Nov 24, 2023
View reviewed changes
Copy link
Member

@paperdave paperdave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, we really need to put this into native code sometime. but this patch fixes the missing functionality.

@paperdave paperdave self-assigned this Nov 24, 2023
@Jarred-Sumner Jarred-Sumner merged commit 194294f into oven-sh:main Nov 25, 2023
19 of 28 checks passed
cirospaciari pushed a commit that referenced this pull request Nov 27, 2023
@samfundev @cirospaciari
fix(node:fs): fix fs.promises.opendir not having a path property (#…
eb17654 
…7292)

Closes #4995
@Zendrex Zendrex mentioned this pull request Nov 28, 2023
Closed
1 task
ryoppippi pushed a commit to ryoppippi/bun that referenced this pull request Feb 1, 2024
@samfundev @ryoppippi
fix(node:fs): fix fs.promises.opendir not having a path property (o…
a5f9b0f 
…ven-sh#7292)

Closes oven-sh#4995
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paperdave paperdave paperdave approved these changes

Assignees

@paperdave paperdave

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

path property is missing in returned object for fs.promises.opendir
3 participants
@samfundev @paperdave @Jarred-Sumner