Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug with readable streams that have been detached #7308

Merged
merged 1 commit into from
Nov 26, 2023

Conversation

Jarred-Sumner
Copy link
Collaborator

What does this PR do?

Fixes #6200 (comment)
Fixes #6821

How did you verify your code works?

This needs a test. I haven't even manually tested this works.

Copy link
Contributor

@Jarred-Sumner 3 files with test failures on bun-darwin-aarch64:

  • test/cli/install/bunx.test.ts
  • test/js/bun/test/test-test.test.ts
  • test/js/web/fetch/body-stream.test.ts

View test output

#ea7a1c2687f693500070272a75b5bb5f19bc45c6

Copy link
Contributor

@Jarred-Sumner 1 files with test failures on linux-x64:

  • test/cli/install/bun-install.test.ts

View test output

#ea7a1c2687f693500070272a75b5bb5f19bc45c6

Copy link
Contributor

@Jarred-Sumner 7 files with test failures on bun-darwin-x64-baseline:

  • test/js/bun/spawn/spawn-streaming-stdout.test.ts
  • test/js/bun/util/which.test.ts
  • test/js/node/fs/fs.test.ts
  • test/js/node/watch/fs.watchFile.test.ts
  • test/js/third_party/postgres/postgres.test.ts
  • test/js/third_party/webpack/webpack.test.ts
  • test/js/web/timers/setTimeout.test.js

View test output

#ea7a1c2687f693500070272a75b5bb5f19bc45c6

@Jarred-Sumner Jarred-Sumner merged commit 5c23d67 into main Nov 26, 2023
18 of 28 checks passed
@Jarred-Sumner Jarred-Sumner deleted the jarred/readable-stream-bug branch November 26, 2023 10:11
cirospaciari pushed a commit that referenced this pull request Nov 27, 2023
Co-authored-by: Jarred Sumner <709451+Jarred-Sumner@users.noreply.github.com>
ryoppippi pushed a commit to ryoppippi/bun that referenced this pull request Feb 1, 2024
Co-authored-by: Jarred Sumner <709451+Jarred-Sumner@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reading stderr of exited process prints out error @google-cloud/storage throws errors with bun
1 participant