Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add import.meta.env to bun-types #7309

Merged
merged 2 commits into from
Nov 25, 2023
Merged

Conversation

RiskyMH
Copy link
Member

@RiskyMH RiskyMH commented Nov 25, 2023

What does this PR do?

import.meta.env was missing from bun types, so I added.

  • Documentation or TypeScript types (it's okay to leave the rest blank in this case)

@Jarred-Sumner Jarred-Sumner merged commit 0abe374 into oven-sh:main Nov 25, 2023
@Jarred-Sumner
Copy link
Collaborator

Thank you

@RiskyMH RiskyMH deleted the patch-1 branch November 25, 2023 06:04
@Jarred-Sumner
Copy link
Collaborator

We should make sure these don't somehow conflict with Vite types

cirospaciari pushed a commit that referenced this pull request Nov 27, 2023
* Add `import.meta.env` to `bun-types`

* add type to codeblock
@jagu-sayan
Copy link

jagu-sayan commented Dec 29, 2023

@cirospaciari Look like it's not supported by the new package @types/bun

ryoppippi pushed a commit to ryoppippi/bun that referenced this pull request Feb 1, 2024
* Add `import.meta.env` to `bun-types`

* add type to codeblock
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants