Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve .vscode extensions, tasks, and configuration #8511

Merged
merged 5 commits into from
Feb 1, 2024
Merged

Conversation

Electroid
Copy link
Contributor

What does this PR do?

  • Removed unused prettier stuff
  • Added more configurations to launch.json, including:
    • --inspect that auto-opens the inspector in the browser
    • More support for Windows
    • Removes older configurations that were unused
  • Organized extensions.json and added more recommended extensions
  • Added to tasks.json for building Bun

.vscode/settings.json Outdated Show resolved Hide resolved
},
"[c]": {
"editor.defaultFormatter": "xaver.clang-format"
},
"files.associations": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if youre fixing this file, i think almost everything in files.associations is useless and should be removed if not needed

scripts/build.sh Outdated Show resolved Hide resolved
.vscode/extensions.json Outdated Show resolved Hide resolved
Copy link
Member

@paperdave paperdave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see above comments

@paperdave
Copy link
Member

also, in my opinion, adding more things to launch.json makes the debugging experience worse. if this file was revamped, it should have been code-generated as a part of the automatic setup process; this way we can include only the windows actions on windows, and the posix actions on posix.

similar feelings to the recommended extensions but to a lesser extent. LLDB is not needed on Windows as we don't use it there. this would lead to installing random extensions without reason (extensions add up and hurt development machine performance, but it's probably fine for this)

@Electroid Electroid merged commit 63a9a8b into main Feb 1, 2024
1 check passed
@Electroid Electroid deleted the vscode-devex branch February 1, 2024 22:55
ryoppippi pushed a commit to ryoppippi/bun that referenced this pull request Feb 2, 2024
Hanaasagi pushed a commit to Hanaasagi/bun that referenced this pull request Feb 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants