-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(windows): fix installing non-ascii paths and make normalizeBuf
generic
#8608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paperdave
approved these changes
Feb 1, 2024
// replace path separators. We can do both of these with our own normalization and utf8/utf16 string conversion code. | ||
var pathname: bun.OSPathSliceZ = if (comptime Environment.isWindows) brk: { | ||
const normalized = bun.path.normalizeBuf( | ||
u16, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yay
generic normalizeBuf
❌ @dylan-conway 4 files with test failures on bun-darwin-aarch64:
|
❌ @dylan-conway 3 files with test failures on linux-x64: |
❌ @dylan-conway 3 files with test failures on linux-x64-baseline: |
❌ @dylan-conway 5 files with test failures on bun-darwin-x64:
|
❌🪟 @dylan-conway, there are 9 test regressions on Windows x86_64
|
ryoppippi
pushed a commit
to ryoppippi/bun
that referenced
this pull request
Feb 2, 2024
…generic (oven-sh#8608) * comptime type normalizeStringBuf * delete * revert * revert revert * revert * remove unused * remove unnecessary assert * add comment * remove normalize, need ../ * use Output.err * update error message * generic T suffix * fix windows build * more fix build * more fix build * mkdiratZ * update test * [autofix.ci] apply automated fixes * update snapshot again * fix merge --------- Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Hanaasagi
pushed a commit
to Hanaasagi/bun
that referenced
this pull request
Feb 3, 2024
…generic (oven-sh#8608) * comptime type normalizeStringBuf * delete * revert * revert revert * revert * remove unused * remove unnecessary assert * add comment * remove normalize, need ../ * use Output.err * update error message * generic T suffix * fix windows build * more fix build * more fix build * mkdiratZ * update test * [autofix.ci] apply automated fixes * update snapshot again * fix merge --------- Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes installing packages with non-ascii paths.
Comment in
libarchive.zig
:Also makes
normalizeBuf
and other functions it uses generic, so they can take u8 or u16 slices. In the future we should update more of our string operations to be generic.How did you verify your code works?
manually tested installing
@fastify/send