New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: id instead of path #8617

Merged

Jarred-Sumner merged 2 commits into main from dylan/fix-module

Feb 1, 2024

Member

dylan-conway commented Feb 1, 2024

What does this PR do?

fixes some tests

How did you verify your code works?

dylan-conway added 2 commits

February 1, 2024 01:50


          use id

0addbfb


          another path

7c8409e

SukkaW reviewed

View reviewed changes

Contributor

SukkaW left a comment

This should fix the error: Cannot find module "./xxxx" from "/path/to/node_modules/xxx" that occurred since an hour ago, right?

Member Author

dylan-conway commented Feb 1, 2024

This should fix the error: Cannot find module "./xxxx" from "/path/to/node_modules/xxx" that occurred since an hour ago, right?

yes, since this commit 2af7cde

Jarred-Sumner merged commit 8191fbd into main

25 of 28 checks passed

Jarred-Sumner deleted the dylan/fix-module branch

February 1, 2024 10:19

Contributor

github-actions bot commented Feb 1, 2024

❌ @dylan-conway 3 files with test failures on bun-darwin-aarch64:

test/cli/test/bun-test.test.ts 1 failing
test/js/node/watch/fs.watchFile.test.ts 1 failing
test/js/third_party/webpack/webpack.test.ts 1 failing

View test output

^{#cba384ad98ea10b59bafd574a1d47e8228ee0c33}

Contributor

github-actions bot commented Feb 1, 2024

❌ @dylan-conway 3 files with test failures on linux-x64:

test/cli/test/bun-test.test.ts 1 failing
test/integration/next/default-pages-dir/test/next-build.test.ts 1 failing
test/js/third_party/webpack/webpack.test.ts 1 failing

View test output

^{#cba384ad98ea10b59bafd574a1d47e8228ee0c33}

Contributor

github-actions bot commented Feb 1, 2024

❌ @dylan-conway 3 files with test failures on linux-x64-baseline:

test/cli/test/bun-test.test.ts 1 failing
test/integration/next/default-pages-dir/test/next-build.test.ts 1 failing
test/js/third_party/webpack/webpack.test.ts 1 failing

View test output

^{#cba384ad98ea10b59bafd574a1d47e8228ee0c33}

Contributor

github-actions bot commented Feb 1, 2024

❌ @dylan-conway 6 files with test failures on bun-darwin-x64:

test/cli/test/bun-test.test.ts 2 failing
test/js/bun/test/test-test.test.ts 1 failing
test/js/bun/util/which.test.ts 1 failing
test/js/node/fs/fs.test.ts 1 failing
test/js/node/watch/fs.watchFile.test.ts 2 failing
test/js/third_party/webpack/webpack.test.ts 1 failing

View test output

^{#cba384ad98ea10b59bafd574a1d47e8228ee0c33}

Contributor

github-actions bot commented Feb 1, 2024

❌🪟 @dylan-conway, there are 9 test regressions on Windows x86_64

test\bundler\cli.test.ts
test\bundler\esbuild\splitting.test.ts
test\cli\inspect\inspect.test.ts
test\cli\run\transpiler-cache.test.ts
test\js\bun\util\bun-file-windows.test.ts
test\js\node\async_hooks\AsyncLocalStorage.test.ts
test\js\node\process\process-args.test.js
test\regression\issue\08095.test.ts
test\transpiler\template-literal.test.ts

Full Test Output

ryoppippi pushed a commit to ryoppippi/bun that referenced this pull request


          fix: id instead of path (oven-sh#8617)

4742c8d

* use id

* another path

Hanaasagi pushed a commit to Hanaasagi/bun that referenced this pull request


          fix: id instead of path (oven-sh#8617)

814b445

* use id

* another path

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet