New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove ZigString.Slice.from #8632

Merged

Jarred-Sumner merged 2 commits into main from nektro-patch-471

Feb 2, 2024

Member

nektro commented Feb 2, 2024

.init is the exact same thing

nektro and others added 2 commits

February 1, 2024 18:36


          remove ZigString.Slice.from .init is the exact same thing

233916b


          Merge branch 'main' into nektro-patch-471

9e11a46

Contributor

github-actions bot commented Feb 2, 2024

❌ @Jarred-Sumner 3 files with test failures on bun-darwin-aarch64:

test/cli/test/bun-test.test.ts 2 failing
test/js/bun/util/inspect-error.test.js 2 failing
test/js/third_party/webpack/webpack.test.ts 1 failing

View test output

^{#71838c476157261e91fa5ce8d053a426c31dcaf1}

Contributor

github-actions bot commented Feb 2, 2024

❌ @Jarred-Sumner 4 files with test failures on linux-x64-baseline:

test/cli/test/bun-test.test.ts 1 failing
test/integration/next/default-pages-dir/test/next-build.test.ts 1 failing
test/js/bun/util/inspect-error.test.js 2 failing
test/js/third_party/webpack/webpack.test.ts 1 failing

View test output

^{#71838c476157261e91fa5ce8d053a426c31dcaf1}

Contributor

github-actions bot commented Feb 2, 2024

❌ @Jarred-Sumner 4 files with test failures on linux-x64:

test/cli/test/bun-test.test.ts 1 failing
test/integration/next/default-pages-dir/test/next-build.test.ts 1 failing
test/js/bun/util/inspect-error.test.js 2 failing
test/js/third_party/webpack/webpack.test.ts 1 failing

View test output

^{#71838c476157261e91fa5ce8d053a426c31dcaf1}

Contributor

github-actions bot commented Feb 2, 2024

❌ @Jarred-Sumner 5 files with test failures on bun-darwin-x64:

test/cli/test/bun-test.test.ts 1 failing
test/js/bun/util/inspect-error.test.js 2 failing
test/js/bun/util/which.test.ts 1 failing
test/js/node/fs/fs.test.ts 1 failing
test/js/third_party/webpack/webpack.test.ts 1 failing

View test output

^{#71838c476157261e91fa5ce8d053a426c31dcaf1}

Jarred-Sumner merged commit 4959c7d into main

26 of 31 checks passed

Jarred-Sumner deleted the nektro-patch-471 branch

February 2, 2024 04:35

ryoppippi pushed a commit to ryoppippi/bun that referenced this pull request


          remove ZigString.Slice.from .init is the exact same thing (oven-sh#8632)

Co-authored-by: Jarred Sumner <jarred@jarredsumner.com>

Contributor

github-actions bot commented Feb 2, 2024

❌🪟 @Jarred-Sumner, there are 11 test regressions on Windows x86_64

test\bundler\cli.test.ts
test\cli\inspect\inspect.test.ts
test\cli\run\transpiler-cache.test.ts
test\js\bun\console\console-iterator.test.ts
test\js\bun\util\bun-file-windows.test.ts
test\js\bun\util\inspect-error.test.js
test\js\node\http\node-http.test.ts
test\js\node\process\process-args.test.js
test\js\node\worker_threads\worker_threads.test.ts
test\regression\issue\08095.test.ts
test\transpiler\template-literal.test.ts

Full Test Output

Hanaasagi pushed a commit to Hanaasagi/bun that referenced this pull request


          remove ZigString.Slice.from .init is the exact same thing (oven-sh#8632)

201b736

Co-authored-by: Jarred Sumner <jarred@jarredsumner.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet