windows: random things #9046
Merged
windows: random things #9046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/bun.js/bindings/BunProcess.cpp
Outdated
| CString utf8 = filename.utf8(); | ||
| HMODULE handle = LoadLibraryA(utf8.data()); | ||
| HMODULE handle; | ||
| printf("Trying to load %s\n", filename.utf8().data()); |
src/bun.js/bindings/BunProcess.cpp
Outdated
| LPSTR messageBuffer = nullptr; | ||
| size_t size = FormatMessageA(FORMAT_MESSAGE_ALLOCATE_BUFFER | FORMAT_MESSAGE_FROM_SYSTEM | FORMAT_MESSAGE_IGNORE_INSERTS, | ||
| NULL, errorId, MAKELANGID(LANG_NEUTRAL, SUBLANG_DEFAULT), (LPSTR)&messageBuffer, 0, NULL); | ||
| WTF::String msg = makeString("LoadLibrary failed: ", WTF::String(messageBuffer, size)); |
There was a problem hiding this comment.
Suggested change
| WTF::String msg = makeString("LoadLibrary failed: ", WTF::String(messageBuffer, size)); | |
| WTF::String msg = makeString("LoadLibrary failed: "_s, WTF::StringView(messageBuffer, size)); |
src/bun.js/javascript.zig
Outdated
| // With trailing slash | ||
| break :name if (dir.len == 1) dir else normalized_specifier[0 .. dir.len + 1]; | ||
| // Normalized with trailing slash | ||
| break :name bun.path.normalizeStringBuf( |
There was a problem hiding this comment.
do we always need to do this extra work?
src/bundler.zig
Outdated
| break :name if (dir.len == 1) dir else entry_point[0 .. dir.len + 1]; | ||
| // Normalized with trailing slash | ||
| break :name bun.path.normalizeStringBuf( | ||
| if (dir.len == 1) dir else entry_point[0 .. dir.len + 1], |
There was a problem hiding this comment.
do we always need to do this extra work?
test/cli/install/bun-pm.test.ts
Outdated
| @@ -338,8 +338,10 @@ it("should remove all cache", async () => { | |||
| import { tmpdir } from "os"; | |||
| it("bun pm migrate", async () => { | |||
| const test_dir = join(tmpdir(), "contoso-test" + Math.random().toString(36).slice(2)); | |||
| console.log("test_dir", test_dir); | |||
There was a problem hiding this comment.
did you mean to commit this?
test/cli/install/bun-pm.test.ts
Outdated
|
|
||
| cpSync(join(import.meta.dir, "migration/contoso-test"), test_dir, { recursive: true }); | ||
| throw new Error("stop"); |
There was a problem hiding this comment.
did you mean to commit this?
Jarred-Sumner
requested changes
Feb 22, 2024
|
❌ @paperdave 2 files with test failures on bun-darwin-aarch64:
|
|
❌ @paperdave 2 files with test failures on linux-x64:
|
|
❌ @paperdave 3 files with test failures on linux-x64-baseline: |
|
✅ test failures on bun-darwin-x64 have been resolved. |
❌🪟 @paperdave, there are 40 test regressions on Windows x86_64
|
|
Thank you |
nikeee
pushed a commit
to nikeee/bun
that referenced
this pull request
Feb 28, 2024
* random things * fix reliability of loading napi stuff * fix posix build * a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?