Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update vite.md #9049

Closed
wants to merge 1 commit into from
Closed

Update vite.md #9049

wants to merge 1 commit into from

Conversation

kacperpaczos
Copy link

@kacperpaczos kacperpaczos commented Feb 22, 2024

  • Added a warning about limited optimization of Vite with Bun at the beginning.
  • Changed the section title to a more formal one.
  • Separated the installation and navigation steps into individual points.
  • Added an explanation of the --bun flag and a note about the shebang line.
  • Updated the "dev" script in package.json, adding the --bun flag.
  • Introduced an example of script configurations for an application.
  • Added a link to the Vite documentation at the end of the document.

What does this PR do?

  • Documentation or TypeScript types (it's okay to leave the rest blank in this case)
  • Code changes

How did you verify your code works?

* Added a warning about limited optimization of Vite with Bun at the beginning.
* Changed the section title to a more formal one.
* Separated the installation and navigation steps into individual points.
* Added an explanation of the --bun flag and a note about the shebang line.
* Updated the "dev" script in package.json, adding the --bun flag.
* Introduced an example of script configurations for an application.
* Added a link to the Vite documentation at the end of the document.
@paperclover
Copy link
Member

this doesnt render well, and i dont understand how the guides formatter actually works.

image

the site isnt public right now, so i don't know what to do about this.

@kacperpaczos
Copy link
Author

the site isnt public right now, so i don't know what to do about this.

What do you mean? I found it on the website...
https://bun.sh/guides/ecosystem/vite

@guyutongxue
Copy link

Notice that bunx --bun vite build doesn't do the same thing as vite build (running under node) because of the inconsistent NODE_ENV. You should use NODE_ENV=production bunx --bun vite build for now, see #7829.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants