feat(Utils): implement isEqual
#1704
Draft
+423
−191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The goal of this PR is reducing the JS bundle size by ditching `lodash` while maintaining the same functionality as before. Series of test were run in order to make sure the newly implemented function works as intended, as well as whether it behaves the same as it `lodash`'s `isEqual()` used to. - `lodash` and it's types are removed. - `vite` and `@vitejs/plugin-react` are bumped to the latest release. - `pnpm-lock.yaml` was completely removed and built anew. - Old size: `~510kb` | New size: `~440kb`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this PR is reducing the JS bundle size by ditching
lodashwhile maintaining the same functionality as before. Series of test were run in order to make sure the newly implemented function works as intended, as well as whether it behaves the same as itlodash'sisEqual()used to.lodashand it's types are removed.viteand@vitejs/plugin-reactare bumped to the latest release.pnpm-lock.yamlwas completely removed and built anew (clean install).Old size:
~510kb| New size:~440kb