feat!: upgrade default mysql charset and collation to utf8mb4 #1084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What? I thought that this upgrade was already part of the redwood branch. If that's not the case then we need to release 18.1.0 ASAP. |
DawoudSheraz
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #938.
Changes
utf8mb4and the default collation toutf8mb4_unicode_ci.dosqlshellcommand to useutf8mb4as the default character set.Testing
tutor [dev|k8s] launchFuture Work
A new do command
tutor local do change-charset-collationto allow users to upgrade the charset and collation of their previous tutor installations will be added in a separate PR. A WIP PR is already up at #1079.