Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove Python 3.8 references #1150

Merged
merged 3 commits into from
Nov 14, 2024

Conversation

DawoudSheraz
Copy link
Contributor

@DawoudSheraz DawoudSheraz commented Oct 29, 2024

Achieves part of #1129,

  • Update Python 3.8 references to 3.9
  • Update Github actions to use 3.9
  • Ensure tests are working as expected on 3.9
  • compile and upgrade requirements on 3.9 base
  • make bundle and make ci-test-bundle are running on 3.9

@regisb
Copy link
Contributor

regisb commented Oct 29, 2024

You will also need to make the following changes:

  1. Bump sphinx version in requirements/docs.in
  2. Remove some items from nitpick_ignore in docs/conf.py.

@DawoudSheraz
Copy link
Contributor Author

You will also need to make the following changes:

  1. Bump sphinx version in requirements/docs.in
  2. Remove some items from nitpick_ignore in docs/conf.py.

I have updated the docs.in the requirements file. As for nitpick_ignore, there were no Python 3.8 specific ignored expressions. I tried removing a few items before Python 3.10 comment but removing them caused the docs to fail locally.

Copy link
Contributor

@regisb regisb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Copy link
Collaborator

@kdmccormick kdmccormick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not review, but Regis's review should be sufficient. 👍🏻

@DawoudSheraz DawoudSheraz merged commit a666732 into master Nov 14, 2024
2 checks passed
@DawoudSheraz DawoudSheraz deleted the dsheraz/remove-py38-references branch November 14, 2024 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

3 participants