Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: new patch for mysql options #1155

Closed
wants to merge 1 commit into from
Closed

feat: new patch for mysql options #1155

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions docs/reference/patches.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,6 +243,13 @@ File: ``local/docker-compose.prod.yml``

File: ``local/docker-compose.yml``

.. patch:: mysql-options

``mysql-options``
=================

File: ``apps/openedx/config/partials/auth.yml``

.. patch:: openedx-auth

``openedx-auth``
Expand Down
1 change: 1 addition & 0 deletions tutor/templates/apps/openedx/config/partials/auth.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,5 +20,6 @@ DATABASES:
{%- if RUN_MYSQL %}
charset: "utf8mb4"
{%- endif %}
{{ patch("mysql-options") }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's not add anything to this file, which I would very much like to see disappear. MySQL settings can already be overridden from the edx-platform common settings. Let's not add useless patches.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. Closing this PR.

EMAIL_HOST_USER: "{{ SMTP_USERNAME }}"
EMAIL_HOST_PASSWORD: "{{ SMTP_PASSWORD }}"
Loading