chore: remove ecommerce plugin as it is deprecated #1181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Faraz32123
commented
Dec 18, 2024
Faraz32123
commented
- remove ecommerce plugin from nightly as it is deprecated.
- check tutor-ecommerce deprecation issue for more info: [DEPR] tutor-ecommerce deprecation tutor-ecommerce#83
- remove ecommerce plugin from nightly as it is deprecated. - check tutor-ecommerce deprecation issue for more info: overhangio/tutor-ecommerce#83
|
tutor-ecommerce was already removed from plugins.txt in tutor main here. Made this PR to remove ecommerce completely from tutor main(nighlty). |
| @@ -282,7 +282,6 @@ class OfficialPlugin(BasePlugin): | |||
| NAMES = [ | |||
| "android", | |||
| "discovery", | |||
| "ecommerce", | |||
There was a problem hiding this comment.
not sure if this should be removed from v0 as it can serve some backwards compatibility purposes.
There was a problem hiding this comment.
yes, this needs to be discussed...
There was a problem hiding this comment.
This class is only meant for the discovery of plugins in the official github-built binary (see make bundle). We don't want the ecommerce plugin there, at least not in the main branch, so we should remove it from this list.
DawoudSheraz
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.