nightly: fix: installation of local requirements #728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `compilejsi18n` command was failing during image building because the Open-edX package was not installed properly. The reason for that was an earlier change where we got rid of the `pip install -r requirements/edx/local.in` command. Installing the Open-edX package was part of this requirement file. The local.in requirements file no longer exists, but we still need to `pip install -e .` the edx-platform repo. To run this command we need both the edx-platform repo and the virtualenv. The good news is that there are no more local requirements in the base.txt requirements file. This means that we no longer have to COPY the edx-platform repo in the requirements installation step. Thus, changes in edx-platform will no longer trigger a rebuild of the pip requirements; this means that re-builds will be much faster when making changes to edx-platform. Note that plugins that implemented the "openedx-dockerfile-post-python-requirements" patch and that needed access to the edx-platform repo will no longer work. Instead, these plugins should implement the "openedx-dockerfile-pre-assets" patch. This scenario should be very rare, though. Close #726
regisb
force-pushed
the
regisb/fix-edx-platform-reqs
branch
from
3add196 to
49ce8b8
Compare
|
I believe that with this change we can close openedx-unsupported/wg-developer-experience#86 right @kdmccormick? |
kdmccormick
approved these changes
Oct 3, 2022
Comment on lines
+79
to
+80
| COPY --from=code /openedx/edx-platform/requirements/edx/base.txt /tmp/base.txt | ||
| RUN pip install -r /tmp/base.txt |
There was a problem hiding this comment.
Totally stylistic, but you could still copy the base.txt file to its typical location. Docker will create all the parent directories for you. Up to you.
Suggested change
| COPY --from=code /openedx/edx-platform/requirements/edx/base.txt /tmp/base.txt | |
| RUN pip install -r /tmp/base.txt | |
| COPY --from=code /openedx/edx-platform/requirements/edx/base.txt /openedx/edx-platform/requirements/edx/base.txt | |
| WORKDIR /openedx/edx-platform | |
| RUN pip install -r ./requirements/edx/base.txt |
|
Yup, this will take care of openedx-unsupported/wg-developer-experience#86! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
compilejsi18ncommand was failing during image building because the Open-edX package was not installed properly. The reason for that was an earlier change where we got rid of thepip install -r requirements/edx/local.incommand. Installing the Open-edX package was part of this requirement file.The local.in requirements file no longer exists, but we still need to
pip install -e .the edx-platform repo. To run this command we need both the edx-platform repo and the virtualenv.The good news is that there are no more local requirements in the base.txt requirements file. This means that we no longer have to COPY the edx-platform repo in the requirements installation step. Thus, changes in edx-platform will no longer trigger a rebuild of the pip requirements; this means that re-builds will be much faster when making changes to edx-platform.
Note that plugins that implemented the
"openedx-dockerfile-post-python-requirements" patch and that needed access to the edx-platform repo will no longer work. Instead, these plugins should implement the "openedx-dockerfile-pre-assets" patch. This scenario should be very rare, though.
Close #726