Fix ShowRecieveStats in the Developer > Avatar menu #1247
+17
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Adjustments * Don't show local stats.
Armored-Dragon
added
bug
|
It seems as if the compiler issues I had noticed are nothing new. |
HifiExperiments
requested changes
Nov 25, 2024
| @@ -1044,7 +1043,7 @@ void Avatar::renderDisplayName(gpu::Batch& batch, const ViewFrustum& view, const | |||
| batch.setModelTransform(textTransform); | |||
| { | |||
| PROFILE_RANGE_BATCH(batch, __FUNCTION__":renderText"); | |||
| displayNameRenderer->draw(batch, { nameUTF8.data(), textColor, { text_x, -text_y }, glm::vec2(-1.0f), forward }); | |||
| displayNameRenderer->draw(batch, { nameUTF8.data(), textColor, { text_x, -text_y }, glm::vec2(10.0f), TextAlignment::CENTER, forward }); | |||
There was a problem hiding this comment.
why 10.0f here? the -1.0f bound is supposed to mean "don't clip this to bounds". if that's broken, maybe we should fix it?
it's possible I broke it when I added GPU bound clipping. specifically, this bit in sdf_text3D.slh probably needs to skip this check if params.bounds is negative:
// Clip to edges. Note: We don't need to check the top edge.
if (positionMS.x < params.bounds.x || positionMS.x > (params.bounds.x + params.bounds.z) ||
positionMS.y < params.bounds.y - params.bounds.w) {
return vec4(0.0);
}
like:
// Clip to edges. Note: We don't need to check the top edge.
if ((params.bounds.x > 0.0 && (positionMS.x < params.bounds.x || positionMS.x > (params.bounds.x + params.bounds.z))) ||
(params.bounds.y > 0.0 && (positionMS.y < params.bounds.y - params.bounds.w))) {
return vec4(0.0);
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt at fixing, or at least making this feature operational, ShowRecieveStats setting.
This renders a users display name along with their networking statistics.
While functional this pull creates a hell of a lot of compiler warnings. While not blocking this is annoying. Until I can quiet down its pleaful cries, this won't be ready to merge.