Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize Overlay #11

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Reorganize Overlay #11

wants to merge 4 commits into from

Conversation

gabehxd
Copy link

@gabehxd gabehxd commented Jan 6, 2021

First time with CSS, sorry about any errors or issues.

@synap5e
Copy link
Collaborator

synap5e commented Jan 12, 2021

Hi

Thanks for this! Adding a full-width mode was something on my list of features I wanted for this extension.
Ideally it would be an option chosen by the streamer, as the current style was decided on based on some feedback with other potential users.

I think making it configurable should be easy with using twitch's configuration service https://dev.twitch.tv/docs/tutorials/extension-101-tutorial-series/config-service

If you are interested in giving that a go, that would help otherwise I will try to find the time to add it myself over the next few weeks.

@gabehxd
Copy link
Author

gabehxd commented Jan 12, 2021

I will look into making the layout a configuration along with opacity. This is my first time using this set of languages/tools so it may not be best quality.

@synap5e
Copy link
Collaborator

synap5e commented Jan 17, 2021

I'm happy to review and provide feedback, or even help with solving the problems you encounter if you would like.

@synap5e
Copy link
Collaborator

synap5e commented Jan 25, 2022

Thanks for this!
I'm in the process of reviewing this and testing it out on twitch - hopefully will be done by this weekend :)

How was the experience of testing/running it while developing? Did you use the twitch extension mode or running the frame externally?

@gabehxd
Copy link
Author

gabehxd commented Jan 28, 2022

I only tested layout changes and I wasn't able to test the config API unfortunately but overall testing the layout changes wasn't too hard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants