Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade node version, delete proxy support (deprecated), add promise support #10

Merged
merged 9 commits into from
Jun 7, 2016
Merged

Upgrade node version, delete proxy support (deprecated), add promise support #10

merged 9 commits into from
Jun 7, 2016

Conversation

bnjjj
Copy link
Contributor

@bnjjj bnjjj commented May 27, 2016

Pay attention you don't have to review the "ovh.es5.js" because it's a transpiled file.

@coveralls
Copy link

coveralls commented May 27, 2016 •
edited
Loading

Coverage Status

Coverage decreased (-1.0%) to 99.029% when pulling 7481598 on upgrade_node_version into 2bcd324 on master.

@bnjjj bnjjj mentioned this pull request May 27, 2016
Closed
VincentCasse
VincentCasse reviewed May 27, 2016
View reviewed changes
lib/ovh.es6.js
@@ -1,6 +1,6 @@
/**
* Copyright (c) 2014 OVH SAS
* Copyright (c) 2012 - 2013 Vincent Giersch
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you keep this line and add your name into ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @VincentCasse (and what a beautiful first name)!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright I'll take care of that. But I think it was important to note who is maintaining this code but ... if you think that's necessary it's the same for me :)

Copy link
Member

@VincentCasse VincentCasse May 27, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. Only because this code was initially did on personal time by @gierschv (and you have a beautiful first name ;) ) and then take into ovh world. So the first copyright (2012-2013) need to be keep.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok I'll change that next week :)
Thanks for your review

@yadutaf
Copy link
Contributor

yadutaf commented May 27, 2016

That's a huge piece of work. Thanks! Can you sign your commits (git commit -s) and add a section, maybe in the readme, to explain how to migrate to 2.0.0, especially for those using the proxy version ?

@bnjjj
Copy link
Contributor Author

bnjjj commented May 28, 2016

Ok thanks I'll think about how can I explain that :). Note that the website documentation is already up to date on my desk

@coveralls
Copy link

coveralls commented May 30, 2016 •
edited
Loading

Coverage Status

Coverage decreased (-1.0%) to 99.029% when pulling 609ffce on upgrade_node_version into 2bcd324 on master.

bnjjj
bnjjj reviewed Jun 5, 2016
View reviewed changes
README.md
@@ -129,6 +140,31 @@ You can browse the API schemas using the web consoles of the APIs:
* [Kimsufi Europe](https://eu.api.kimsufi.com/console/)
* [Kimsufi North-America](https://ca.api.kimsufi.com/console/)

## Migration from 1.x.x to 2.x.x without Proxy support
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yadutaf Is it right for you ?

@coveralls
Copy link

coveralls commented Jun 5, 2016 •
edited
Loading

Coverage Status

Coverage decreased (-1.0%) to 99.029% when pulling 0ea5cb8 on upgrade_node_version into 2bcd324 on master.

@coveralls
Copy link

coveralls commented Jun 5, 2016 •
edited
Loading

Coverage Status

Coverage decreased (-1.0%) to 99.029% when pulling 0ea5cb8 on upgrade_node_version into 2bcd324 on master.

bnjjj and others added 9 commits June 6, 2016 11:34
@bnjjj
test (version): test with more node versions
030e587 
Signed-off-by: Benjamin Coenen <benjamin.coenen@corp.ovh.com>
@bnjjj
feat(ovh): remove proxy and add es6 support
a7c955e 
Signed-off-by: Benjamin Coenen <benjamin.coenen@corp.ovh.com>
@bnjjj
feat(ovh): up node version support and add promise support (issue: #9)
b48df61 
Signed-off-by: Benjamin Coenen <benjamin.coenen@corp.ovh.com>
@bnjjj
docs(README): update readme with new functions
310a2c0 
Signed-off-by: Benjamin Coenen <benjamin.coenen@corp.ovh.com>
@bnjjj
docs(ovh): documentation about requestPromised
82b9c83 
Signed-off-by: Benjamin Coenen <benjamin.coenen@corp.ovh.com>
@bnjjj
fix(tests): delete arrow functions
6da8bed 
Signed-off-by: Benjamin Coenen <benjamin.coenen@corp.ovh.com>
@bnjjj
refactor(ovh): refactor and improvements for review
33db1dd 
Signed-off-by: Benjamin Coenen <benjamin.coenen@corp.ovh.com>
@bnjjj
docs(README): add migration from 1.x.x to 2.x.x
9a6dac5 
Signed-off-by: Benjamin Coenen <benjamin.coenen@corp.ovh.com>
@bnjjj
bump version to 2.0.0
7dcba97 
Signed-off-by: Benjamin Coenen <benjamin.coenen@corp.ovh.com>
@bnjjj bnjjj force-pushed the upgrade_node_version branch from 4088195 to 7dcba97 Compare June 6, 2016 10:00
@yadutaf yadutaf merged commit 835a178 into master Jun 7, 2016
@yadutaf yadutaf deleted the upgrade_node_version branch June 7, 2016 14:05
@yadutaf
Copy link
Contributor

yadutaf commented Jun 7, 2016

Great work! Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bnjjj @coveralls @yadutaf @gierschv @VincentCasse