Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update request functions to handle 201/204 success status codes #50

Merged
merged 1 commit into from
Oct 9, 2023

Conversation

Clovel
Copy link
Contributor

@Clovel Clovel commented Oct 4, 2023

For example, the /domain/zone/{zoneName}/record/{id} DELETE route now returns a 204 success status code, but this lib throws an exception because of that.

@rbeuque74 rbeuque74 self-requested a review October 5, 2023 07:06
@rbeuque74 rbeuque74 merged commit 224296c into ovh:master Oct 9, 2023
@rbeuque74
Copy link
Member

Thanks for your contribution @Clovel
We will release a new version on npmjs soon.

@Clovel
Copy link
Contributor Author

Clovel commented Nov 7, 2023

We will release a new version on npmjs soon.

Any news on this @rbeuque74 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants