Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply string to class constant #139

Merged
merged 1 commit into from
Jan 2, 2024
Merged

Conversation

peter279k
Copy link
Contributor

Changed log

  • Using the string class constant approach to replace the string class name.

Signed-off-by: peter279k <peter279k@gmail.com>
@rbeuque74
Copy link
Member

Hello,
Thanks for your contribution.

What is the compatibility of this modification with our PHP versions support? (Compatible with PHP 7.4, 8.0, 8.1, 8.2.)

Thanks
Romain

@peter279k
Copy link
Contributor Author

peter279k commented Oct 13, 2023

According to the reference, the feature is compatible with PHP 7.4+ version because it's available since PHP 5.5 version.

@codecov
Copy link

codecov bot commented Oct 13, 2023

Codecov Report

Merging #139 (13c0992) into master (d4840af) will not change coverage.
Report is 3 commits behind head on master.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #139   +/-   ##
=========================================
  Coverage     97.52%   97.52%           
  Complexity       36       36           
=========================================
  Files             1        1           
  Lines           121      121           
=========================================
  Hits            118      118           
  Misses            3        3           

@deathiop deathiop merged commit 2b2095a into ovh:master Jan 2, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants