Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Kubeflow on PCI #83

Merged
merged 16 commits into from
Nov 25, 2024
Merged

feat: Kubeflow on PCI #83

merged 16 commits into from
Nov 25, 2024

Conversation

sguyennet
Copy link
Contributor

No description provided.

@philippart-s
Copy link
Collaborator

👋 @scraly 👀

@philippart-s philippart-s requested a review from scraly October 4, 2024 07:17
@scraly
Copy link
Collaborator

scraly commented Oct 4, 2024

Thanks for the notification, yes it's already in my Todo list 😊😊😊

@sguyennet sguyennet force-pushed the dev/sgu/kubeflow-on-pci branch from 5368868 to d786ad7 Compare October 14, 2024 08:15
Copy link
Collaborator

@scraly scraly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Simon for the PR! :)

Here my second review with remarks :)

use-cases/kubeflow/README.md Show resolved Hide resolved
use-cases/kubeflow/README.md Outdated Show resolved Hide resolved
use-cases/kubeflow/README.md Outdated Show resolved Hide resolved
use-cases/kubeflow/README.md Outdated Show resolved Hide resolved
use-cases/kubeflow/README.md Outdated Show resolved Hide resolved
use-cases/kubeflow/README.md Outdated Show resolved Hide resolved
use-cases/kubeflow/README.md Outdated Show resolved Hide resolved
use-cases/kubeflow/README.md Outdated Show resolved Hide resolved
use-cases/kubeflow/provider.tf Outdated Show resolved Hide resolved
@scraly
Copy link
Collaborator

scraly commented Nov 4, 2024

Moreover, what about giving at the end of the README, a "hello world" for KubeFlow? A starting point to use our newly deployed kubeflow? :)

@scraly
Copy link
Collaborator

scraly commented Nov 4, 2024

And in the provider.tf file, in the aws provider section, I think you just have to defined creds and use high perf bucket instead of old one:

 endpoints = {
        s3 = "https://s3.<region_in_lowercase>.perf.cloud.ovh.net/"
      }   
# The following fields should be added if your S3 user credentials are not
      # already configured in files ~/.aws/credentials, ~/.aws/config or in
      # environment variables.
      access_key                  = "s3 user access key"
      secret_key                  = "s3 user secret key"  

WDYT?

use-cases/kubeflow/README.md Outdated Show resolved Hide resolved
use-cases/kubeflow/README.md Show resolved Hide resolved
use-cases/kubeflow/README.md Outdated Show resolved Hide resolved
use-cases/kubeflow/README.md Show resolved Hide resolved
@sguyennet sguyennet force-pushed the dev/sgu/kubeflow-on-pci branch from a699af2 to 71c7a03 Compare November 4, 2024 16:00
use-cases/kubeflow/helm_external_dns.tf Outdated Show resolved Hide resolved
use-cases/kubeflow/helm_external_dns.tf Outdated Show resolved Hide resolved
use-cases/kubeflow/helm_external_dns.tf Outdated Show resolved Hide resolved
use-cases/kubeflow/helm_external_dns.tf Outdated Show resolved Hide resolved
use-cases/kubeflow/helm_external_dns.tf Outdated Show resolved Hide resolved
use-cases/kubeflow/README.md Show resolved Hide resolved
use-cases/kubeflow/README.md Show resolved Hide resolved
use-cases/kubeflow/README.md Show resolved Hide resolved
use-cases/kubeflow/README.md Show resolved Hide resolved
use-cases/kubeflow/README.md Show resolved Hide resolved
@sguyennet sguyennet force-pushed the dev/sgu/kubeflow-on-pci branch from c648ea5 to addacae Compare November 5, 2024 09:06
@sguyennet
Copy link
Contributor Author

Moreover, what about giving at the end of the README, a "hello world" for KubeFlow? A starting point to use our newly deployed kubeflow? :)

Done

@sguyennet
Copy link
Contributor Author

And in the provider.tf file, in the aws provider section, I think you just have to defined creds and use high perf bucket instead of old one:

 endpoints = {
        s3 = "https://s3.<region_in_lowercase>.perf.cloud.ovh.net/"
      }   
# The following fields should be added if your S3 user credentials are not
      # already configured in files ~/.aws/credentials, ~/.aws/config or in
      # environment variables.
      access_key                  = "s3 user access key"
      secret_key                  = "s3 user secret key"  

WDYT?

I changed for high perf bucket

use-cases/kubeflow/README.md Outdated Show resolved Hide resolved
use-cases/kubeflow/README.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@scraly scraly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a blocking error during the terraform plan command execution.
The AWS provider can't be initialized because credentials are not given (we can't define a parameter with a resource that will be created after).

Copy link
Collaborator

@scraly scraly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remarks for troubleshooting in kubernetes

use-cases/kubeflow/README.md Outdated Show resolved Hide resolved
use-cases/kubeflow/README.md Outdated Show resolved Hide resolved
@scraly
Copy link
Collaborator

scraly commented Nov 8, 2024

FYI There is a usage of a deprecated resource:
image

Copy link
Collaborator

@scraly scraly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sguyennet ping me again when wyou'll have time to fix last changes requests :)

@sguyennet
Copy link
Contributor Author

FYI There is a usage of a deprecated resource: image

This is fixed

@sguyennet sguyennet force-pushed the dev/sgu/kubeflow-on-pci branch from 26ce574 to 796f30a Compare November 22, 2024 09:43
use-cases/kubeflow/README.md Outdated Show resolved Hide resolved
@sguyennet sguyennet force-pushed the dev/sgu/kubeflow-on-pci branch from 796f30a to 33a3d39 Compare November 22, 2024 15:16
@scraly scraly merged commit 8c40087 into ovh:main Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants