-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Kubeflow on PCI #83
Conversation
👋 @scraly 👀 |
Thanks for the notification, yes it's already in my Todo list 😊😊😊 |
5368868
to
d786ad7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Simon for the PR! :)
Here my second review with remarks :)
Moreover, what about giving at the end of the README, a "hello world" for KubeFlow? A starting point to use our newly deployed kubeflow? :) |
And in the provider.tf file, in the aws provider section, I think you just have to defined creds and use high perf bucket instead of old one:
WDYT? |
a699af2
to
71c7a03
Compare
c648ea5
to
addacae
Compare
Done |
I changed for high perf bucket |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a blocking error during the terraform plan command execution.
The AWS provider can't be initialized because credentials are not given (we can't define a parameter with a resource that will be created after).
…the aws s3 token nd then pass it to the kubeflow module
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remarks for troubleshooting in kubernetes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sguyennet ping me again when wyou'll have time to fix last changes requests :)
26ce574
to
796f30a
Compare
796f30a
to
33a3d39
Compare
No description provided.