collector: switch to SKIP LOCKED #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When µTask is used with a lot of tasks, lock on the postgres can take a lot of memory as the `pg_try_advisory_xact_lock` lock function will try to lock all the rows. As Postgres 9.5+ now handle `SKIP LOCKED` keyword, it can be used to try to acquire only one row, without locking all the existing resolution. The lock will also be scopped at the table level, instead of the Postgres cluster level previously. Signed-off-by: Romain Beuque <556072+rbeuque74@users.noreply.github.com>
Alkorin
approved these changes
May 25, 2021
wI2L
approved these changes
May 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Bug fix
What is the current behavior? (You can also link to an open issue here)
When µTask is used with a lot of tasks, lock on the postgres can take
a lot of memory as the
pg_try_advisory_xact_locklock function willtry to lock all the rows. As Postgres 9.5+ now handle
SKIP LOCKEDkeyword, it can be used to try to acquire only one row, without locking
all the existing resolution. The lock will also be scopped at the table
level, instead of the Postgres cluster level previously.
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No
Other information: