Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: task: add resolver_usernames to POST /task #306

Merged
merged 1 commit into from
Jan 19, 2022

Conversation

rbeuque74
Copy link
Member

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Feature

  • What is the new behavior (if this is a feature change)?
    Adding resolver_usernames as input for POST /task to allow admins and template owners to add more resolvers to a task.
    This allow to give control to more users over a task. Usefull in case the task is created by an automated process, and we want to let users control over the task execution.

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
    No

  • Other information:

@rbeuque74 rbeuque74 requested review from loopfz and wI2L December 24, 2021 11:33
api/handler/task.go Outdated Show resolved Hide resolved
api/handler/task.go Outdated Show resolved Hide resolved
Signed-off-by: Romain Beuque <556072+rbeuque74@users.noreply.github.com>
@rbeuque74 rbeuque74 force-pushed the create-task-resolver-usernames branch from 6c32745 to e637fa3 Compare December 24, 2021 11:50
@rbeuque74 rbeuque74 requested a review from Alkorin December 24, 2021 11:50
@rbeuque74 rbeuque74 merged commit 9da2f52 into master Jan 19, 2022
@rbeuque74 rbeuque74 deleted the create-task-resolver-usernames branch January 19, 2022 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants