feat(notify): use logrus to capture errors #365
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improvement: use logrus to capture errors from Send Notify to standardize the errors logs.
The error logs aren't standardized.
All notify backend use the same function to capture an error and the error logs are standardized.
Also, some fields have been added to simplify the debug.
The format of error logs has changed to be standardized with the rest of the application. In case where an alerting system that parses the logs is used, the users need to change their configuration/rules.
An example of
notify_config
to test the new behaviour: