Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(subtask): do not auto-resume parent task of subtask if parent resolution is paused #367

Merged
merged 3 commits into from
Oct 14, 2022

Conversation

rbeuque74
Copy link
Member

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Bug fix

  • What is the current behavior? (You can also link to an open issue here)
    Most of the time, parent resolution in state Paused means that an human operator has stopped the processing for patch management. We should not auto-resume the parent task to prevent any issue.

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
    No that much

  • Other information:

…olution is paused

Most of the time, parent resolution in state Paused means that an human
operator has stopped the processing for patch management. We should not
auto-resume the parent task to prevent any issue.

Signed-off-by: Romain Beuque <556072+rbeuque74@users.noreply.github.com>
@rbeuque74 rbeuque74 requested a review from loopfz as a code owner October 12, 2022 17:18
@ovh-cds
Copy link
Collaborator

ovh-cds commented Oct 12, 2022

CDS Report test#1439.0 ✘

  • tests and lint
    • golangci-lint ✘
    • unit-test and integration-tests ✔

@rbeuque74 rbeuque74 requested review from Inozuma and wI2L October 13, 2022 13:19
@ovh-cds
Copy link
Collaborator

ovh-cds commented Oct 13, 2022

CDS Report test#1439.1 ✘

  • tests and lint
    • golangci-lint ✘
    • unit-test and integration-tests ✔

wI2L
wI2L previously approved these changes Oct 13, 2022
…ic-imports

Signed-off-by: Romain Beuque <556072+rbeuque74@users.noreply.github.com>
@rbeuque74
Copy link
Member Author

Can be reviewed using the 2 commits for more clarity ;)

@ovh-cds
Copy link
Collaborator

ovh-cds commented Oct 13, 2022

CDS Report test#1440.0 ✘

  • tests and lint
    • golangci-lint ✔
    • unit-test and integration-tests ✘

@rbeuque74 rbeuque74 merged commit 02f7721 into master Oct 14, 2022
@rbeuque74 rbeuque74 deleted the dev/rbeuque/fix-resume-paused-resolution branch October 14, 2022 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants