fix(plugin): Fixed batch plugin stuck when underlying batch is collected #543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DrRebus
requested review from
rbeuque74,
loopfz,
rclsilver and
wI2L
as code owners
wI2L
reviewed
Dec 13, 2024
Signed-off-by: Ruben Tordjman <144785435+DrRebus@users.noreply.github.com>
DrRebus
force-pushed
the
rtordjma/fix-batch-plugin-collected-batch
branch
from
3feea18 to
43de193
Compare
wI2L
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Bug fix and an improvement for the batch plugin
What is the current behavior? (You can also link to an open issue here)
Steps using the batch plugin sometimes get stuck in the "WAITING" state because their underlying batch (in the database) was garbage-collected before they were able to populate it again.
What is the new behavior (if this is a feature change)?
The batch plugin no longer stay stuck in the "WAITING" state; it re-creates the batch with the same public ID and populates it.
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Yes, the
sub_batch_sizeparameter of the batch plugin now expects a string instead of a number to support both hardcoded values (e.g.: "5") and templated ones (e.g.: "{{ .config.myconfig.batch_size }}").Other information: