Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timeout declared two times in venom language #290

Closed
kevinramage opened this issue Oct 26, 2020 · 1 comment · Fixed by #324
Closed

Timeout declared two times in venom language #290

kevinramage opened this issue Oct 26, 2020 · 1 comment · Fixed by #324
Assignees
Labels

Comments

@kevinramage
Copy link
Contributor

Hello,

I work on a visual studio code extension for venom language and I see a strange point on venom language.
I see two attributes timeout, one native with executor (like delay and retry) and one dedicated to kafka executor.
The first one is declared as int, the second one declared as int64.

Do you think this two differents definition can impact the system ?
It's necessary to declare timeout attribute for Kafka system ?

Regards

@fsamin fsamin added the bug label Nov 19, 2020
@fsamin
Copy link
Member

fsamin commented Nov 19, 2020

Technically, having two definitions is not really a problem, event if it is a bit weird.

But your right: it is useless to handle a specific timeout for context cancellation in the kafka executor because it already done in the layer above.
The funny thing is that the same timeout value is handled in venom in second and in millisecond in kafka

It is a bug and should be fixed

yesnault added a commit that referenced this issue Nov 21, 2020
close #290

Signed-off-by: Yvonnick Esnault <yvonnick.esnault@corp.ovh.com>
@yesnault yesnault self-assigned this Nov 22, 2020
fsamin pushed a commit that referenced this issue Nov 23, 2020
close #290

Signed-off-by: Yvonnick Esnault <yvonnick.esnault@corp.ovh.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants