-
-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert createWriteStream
to createWriteStreamSync
#57
Convert createWriteStream
to createWriteStreamSync
#57
Conversation
17e20d5
to
979c138
Compare
Running tests locally, I'm getting some confusing timeouts..
|
Turns out, test output is unchanged relative to master, diff here: e283e74 |
95b24eb
to
1f6fd13
Compare
Somehow this improves coverage from this: ------------------------|---------|----------|---------|---------|------------------- File | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s ------------------------|---------|----------|---------|---------|------------------- All files | 38.75 | 20.83 | 37.5 | 45.45 | applicationinsights.js | 16.95 | 5 | 16.67 | 21.74 | 9,18-76,83-87 To: ------------------------|---------|----------|---------|---------|------------------- File | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s ------------------------|---------|----------|---------|---------|------------------- All files | 98.78 | 100 | 100 | 98.53 | applicationinsights.js | 98.36 | 100 | 100 | 97.92 | 91
This happens in commit b2a3c2a applicationinsights.ts - un-promise-ify Does not make any sense to me 🤷
1f6fd13
to
830e2a8
Compare
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Well that's sad |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Users will get an import error when updating.
I think it should be pretty easy to fix.
This is a smaller diff of just the src changes, with no refactoring, no test updates, no doc updates, etc: #59
It will be easier first to understand the src changes in that PR
Checklist
npm run test
Also adding a jsdoc typescript signature.
Closes #56