ARC-1222: Bootstrap Relying Party OIDC Server #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasrichner-oviva
force-pushed
the
feature/arc-1222
branch
3 times, most recently
from
610118e
to
695638c
Compare
Comment on lines
+44
to
+46
| var baseUri = URI.create("https://t.oviva.io"); | ||
| var validRedirectUris = | ||
| List.of(URI.create("https://idp-test.oviva.io/auth/realms/master/broker/oidc/endpoint")); |
There was a problem hiding this comment.
for now hardcoded, makes developing much faster
There was a problem hiding this comment.
maybe add an explicit TODO comment in code? so it easier to fetch it again later
oidc-server/src/main/java/com/oviva/gesundheitsid/relyingparty/Main.java
Show resolved
Hide resolved
thomasrichner-oviva
force-pushed
the
feature/arc-1222
branch
from
695638c
to
ebb24fc
Compare
thomasrichner-oviva
force-pushed
the
feature/arc-1222
branch
from
ecad68b
to
86c35af
Compare
|
michelealbanese-oviva
approved these changes
Feb 5, 2024
Comment on lines
+44
to
+46
| var baseUri = URI.create("https://t.oviva.io"); | ||
| var validRedirectUris = | ||
| List.of(URI.create("https://idp-test.oviva.io/auth/realms/master/broker/oidc/endpoint")); |
There was a problem hiding this comment.
maybe add an explicit TODO comment in code? so it easier to fetch it again later
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements a very basic OpenID Connect IDP. The idea is to just defer authentication to this standalone bit from Keycloak. OIDC is supported out of the box.
This will imply an additional thing to deploy, but we will need minimal changes to Keycloak!
This PR adds a very basic implementation that can complete the authentication, but does not ask for credentials and also does not further deal with the actual gesundheits ID federation.
Next up will be wiring in GesundheitsID.
Other open todos: