Skip to content

Commit

Permalink
Obtaining e2e_timestamp metric value using the unix socket.
Browse files Browse the repository at this point in the history
Included a check for empty output when retrieving e2e_timestamp value
in the ovnE2eTimeStampUpdater().

Signed-off-by: Pardhakeswar Pacha <ppacha@nvidia.com>
  • Loading branch information
Pardhakeswar authored and girishmg committed Jul 25, 2020
1 parent cd21800 commit cdb174c
Showing 1 changed file with 10 additions and 6 deletions.
16 changes: 10 additions & 6 deletions go-controller/cmd/ovn-kube-util/app/ovn-db-exporter.go
Original file line number Diff line number Diff line change
Expand Up @@ -269,22 +269,26 @@ func ovnE2eTimeStampUpdater(direction, database string) {
var err error

if direction == "sb" {
stdout, stderr, err = util.RunOVNSbctl("--if-exists", "--no-leader-only",
stdout, stderr, err = util.RunOVNSbctlUnix("--if-exists", "--no-leader-only",
"get", "SB_Global", ".", "options:e2e_timestamp")
} else {
stdout, stderr, err = util.RunOVNNbctl("--if-exists", "--no-leader-only",
stdout, stderr, err = util.RunOVNNbctlUnix("--if-exists", "--no-leader-only",
"get", "NB_Global", ".", "options:e2e_timestamp")
}
if err != nil {
klog.Errorf("Failed to scrape timestamp for database %s: "+
"stderr (%s) (%v)", database, stderr, err)
return
}
if value, err := strconv.ParseFloat(stdout, 64); err == nil {
metricDBE2eTimestamp.WithLabelValues(database).Set(value)
if stdout != "" {
if value, err := strconv.ParseFloat(stdout, 64); err == nil {
metricDBE2eTimestamp.WithLabelValues(database).Set(value)
} else {
klog.Errorf("Failed to parse %s e2e-timestamp value to float64 :(%v)",
database, err)
}
} else {
klog.Errorf("Failed to parse %s e2e-timestamp value to float64 :(%v)",
database, err)
metricDBE2eTimestamp.WithLabelValues(database).Set(0)
}
}

Expand Down

0 comments on commit cdb174c

Please sign in to comment.