Do not assume pod is always in cache on delete #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do we need similar changes for _update_service_cache in ovn_k8s/watcher/service_watcher.py and ovn_k8s/modes/overlay.py |
|
I did not do the change there because I did not find any case where it would fail - for the pod case I verified the watcher fails when the scheduler is down and a pod is deleted. Anyway, we can do that - just to err on the safe side. |
|
Please go ahead and update the PR. |
Replace del statement with pop method, in order to avoid watcher failures due to KeyError when deleting a pod. There is at least one corner case where a pod is never processed and therefore never stored in cache, and that would be when the kube scheduler is down and does not come up before the pod is deleted. It is worth noting however that the observed failure is not critical as the watcher is restarted. Signed-off-by: Salvatore Orlando <salv.orlando@gmail.com>
salv-orlando
force-pushed
the
pop_cache
branch
from
33c37a5
to
06a8017
Compare
|
LGTM. |
This was referenced Sep 14, 2016
pecameron
pushed a commit
to pecameron/ovn-kubernetes
that referenced
this pull request
Sep 12, 2019
Do not install arch-specific dependencies
Billy99
added a commit
to Billy99/ovn-kubernetes-1
that referenced
this pull request
Jul 20, 2020
ebay/libovsdb had the following issue that was fixed upstream: Allow libovsdb to connnect to ovsdb instance over IPv6 connection. (ovn-org#20) When trying to connect to an ovsdb instance via IPv6, encountered an IPv6 parsing issue. In the logic to strip off the leading protocol (i.e. tcp:...), the code uses strings.Split(endpoint, ":"), which does not take into account the ':' in an IPv6 address. Signed-off-by: Billy McFall <22157057+Billy99@users.noreply.github.com>
Billy99
added a commit
to Billy99/ovn-kubernetes-1
that referenced
this pull request
Jul 20, 2020
ebay/libovsdb had the following issue that was fixed upstream: Allow libovsdb to connnect to ovsdb instance over IPv6 connection. (ovn-org#20) When trying to connect to an ovsdb instance via IPv6, encountered an IPv6 parsing issue. In the logic to strip off the leading protocol (i.e. tcp:...), the code uses strings.Split(endpoint, ":"), which does not take into account the ':' in an IPv6 address. Signed-off-by: Billy McFall <22157057+Billy99@users.noreply.github.com>
Billy99
added a commit
to Billy99/ovn-kubernetes-1
that referenced
this pull request
Jul 21, 2020
ebay/libovsdb had the following issue that was fixed upstream: Allow libovsdb to connnect to ovsdb instance over IPv6 connection. (ovn-org#20) When trying to connect to an ovsdb instance via IPv6, encountered an IPv6 parsing issue. In the logic to strip off the leading protocol (i.e. tcp:...), the code uses strings.Split(endpoint, ":"), which does not take into account the ':' in an IPv6 address. Signed-off-by: Billy McFall <22157057+Billy99@users.noreply.github.com>
Billy99
added a commit
to Billy99/ovn-kubernetes-1
that referenced
this pull request
Jul 22, 2020
ebay/libovsdb had the following issue that was fixed upstream: Allow libovsdb to connnect to ovsdb instance over IPv6 connection. (ovn-org#20) When trying to connect to an ovsdb instance via IPv6, encountered an IPv6 parsing issue. In the logic to strip off the leading protocol (i.e. tcp:...), the code uses strings.Split(endpoint, ":"), which does not take into account the ':' in an IPv6 address. Signed-off-by: Billy McFall <22157057+Billy99@users.noreply.github.com>
Billy99
added a commit
to Billy99/ovn-kubernetes-1
that referenced
this pull request
Jul 22, 2020
ebay/libovsdb had the following issue that was fixed upstream: Allow libovsdb to connnect to ovsdb instance over IPv6 connection. (ovn-org#20) When trying to connect to an ovsdb instance via IPv6, encountered an IPv6 parsing issue. In the logic to strip off the leading protocol (i.e. tcp:...), the code uses strings.Split(endpoint, ":"), which does not take into account the ':' in an IPv6 address. Signed-off-by: Billy McFall <22157057+Billy99@users.noreply.github.com>
Billy99
added a commit
to Billy99/ovn-kubernetes-1
that referenced
this pull request
Jul 23, 2020
ebay/libovsdb had the following issue that was fixed upstream: Allow libovsdb to connnect to ovsdb instance over IPv6 connection. (ovn-org#20) When trying to connect to an ovsdb instance via IPv6, encountered an IPv6 parsing issue. In the logic to strip off the leading protocol (i.e. tcp:...), the code uses strings.Split(endpoint, ":"), which does not take into account the ':' in an IPv6 address. Signed-off-by: Billy McFall <22157057+Billy99@users.noreply.github.com>
Billy99
added a commit
to Billy99/ovn-kubernetes-1
that referenced
this pull request
Jul 23, 2020
ebay/libovsdb had the following issue that was fixed upstream: Allow libovsdb to connnect to ovsdb instance over IPv6 connection. (ovn-org#20) When trying to connect to an ovsdb instance via IPv6, encountered an IPv6 parsing issue. In the logic to strip off the leading protocol (i.e. tcp:...), the code uses strings.Split(endpoint, ":"), which does not take into account the ':' in an IPv6 address. Signed-off-by: Billy McFall <22157057+Billy99@users.noreply.github.com>
Billy99
added a commit
to Billy99/ovn-kubernetes-1
that referenced
this pull request
Jul 24, 2020
ebay/libovsdb had the following issue that was fixed upstream: Allow libovsdb to connnect to ovsdb instance over IPv6 connection. (ovn-org#20) When trying to connect to an ovsdb instance via IPv6, encountered an IPv6 parsing issue. In the logic to strip off the leading protocol (i.e. tcp:...), the code uses strings.Split(endpoint, ":"), which does not take into account the ':' in an IPv6 address. Signed-off-by: Billy McFall <22157057+Billy99@users.noreply.github.com>
Billy99
added a commit
to Billy99/ovn-kubernetes-1
that referenced
this pull request
Jul 24, 2020
ebay/libovsdb had the following issue that was fixed upstream: Allow libovsdb to connnect to ovsdb instance over IPv6 connection. (ovn-org#20) When trying to connect to an ovsdb instance via IPv6, encountered an IPv6 parsing issue. In the logic to strip off the leading protocol (i.e. tcp:...), the code uses strings.Split(endpoint, ":"), which does not take into account the ':' in an IPv6 address. Signed-off-by: Billy McFall <22157057+Billy99@users.noreply.github.com>
Billy99
added a commit
to Billy99/ovn-kubernetes-1
that referenced
this pull request
Jul 24, 2020
ebay/libovsdb had the following issue that was fixed upstream: Allow libovsdb to connnect to ovsdb instance over IPv6 connection. (ovn-org#20) When trying to connect to an ovsdb instance via IPv6, encountered an IPv6 parsing issue. In the logic to strip off the leading protocol (i.e. tcp:...), the code uses strings.Split(endpoint, ":"), which does not take into account the ':' in an IPv6 address. Signed-off-by: Billy McFall <22157057+Billy99@users.noreply.github.com>
Billy99
added a commit
to Billy99/ovn-kubernetes-1
that referenced
this pull request
Jul 24, 2020
ebay/libovsdb had the following issue that was fixed upstream: Allow libovsdb to connnect to ovsdb instance over IPv6 connection. (ovn-org#20) When trying to connect to an ovsdb instance via IPv6, encountered an IPv6 parsing issue. In the logic to strip off the leading protocol (i.e. tcp:...), the code uses strings.Split(endpoint, ":"), which does not take into account the ':' in an IPv6 address. Signed-off-by: Billy McFall <22157057+Billy99@users.noreply.github.com>
Billy99
added a commit
to Billy99/ovn-kubernetes-1
that referenced
this pull request
Jul 25, 2020
ebay/libovsdb had the following issue that was fixed upstream: Allow libovsdb to connnect to ovsdb instance over IPv6 connection. (ovn-org#20) When trying to connect to an ovsdb instance via IPv6, encountered an IPv6 parsing issue. In the logic to strip off the leading protocol (i.e. tcp:...), the code uses strings.Split(endpoint, ":"), which does not take into account the ':' in an IPv6 address. Signed-off-by: Billy McFall <22157057+Billy99@users.noreply.github.com>
Billy99
added a commit
to Billy99/ovn-kubernetes-1
that referenced
this pull request
Jul 25, 2020
ebay/libovsdb had the following issue that was fixed upstream: Allow libovsdb to connnect to ovsdb instance over IPv6 connection. (ovn-org#20) When trying to connect to an ovsdb instance via IPv6, encountered an IPv6 parsing issue. In the logic to strip off the leading protocol (i.e. tcp:...), the code uses strings.Split(endpoint, ":"), which does not take into account the ':' in an IPv6 address. Signed-off-by: Billy McFall <22157057+Billy99@users.noreply.github.com>
Billy99
added a commit
to Billy99/ovn-kubernetes-1
that referenced
this pull request
Jul 27, 2020
ebay/libovsdb had the following issue that was fixed upstream: Allow libovsdb to connnect to ovsdb instance over IPv6 connection. (ovn-org#20) When trying to connect to an ovsdb instance via IPv6, encountered an IPv6 parsing issue. In the logic to strip off the leading protocol (i.e. tcp:...), the code uses strings.Split(endpoint, ":"), which does not take into account the ':' in an IPv6 address. Signed-off-by: Billy McFall <22157057+Billy99@users.noreply.github.com>
Billy99
added a commit
to Billy99/ovn-kubernetes-1
that referenced
this pull request
Jul 27, 2020
ebay/libovsdb had the following issue that was fixed upstream: Allow libovsdb to connnect to ovsdb instance over IPv6 connection. (ovn-org#20) When trying to connect to an ovsdb instance via IPv6, encountered an IPv6 parsing issue. In the logic to strip off the leading protocol (i.e. tcp:...), the code uses strings.Split(endpoint, ":"), which does not take into account the ':' in an IPv6 address. Signed-off-by: Billy McFall <22157057+Billy99@users.noreply.github.com>
Billy99
added a commit
to Billy99/ovn-kubernetes-1
that referenced
this pull request
Jul 27, 2020
ebay/libovsdb had the following issue that was fixed upstream: Allow libovsdb to connnect to ovsdb instance over IPv6 connection. (ovn-org#20) When trying to connect to an ovsdb instance via IPv6, encountered an IPv6 parsing issue. In the logic to strip off the leading protocol (i.e. tcp:...), the code uses strings.Split(endpoint, ":"), which does not take into account the ':' in an IPv6 address. Signed-off-by: Billy McFall <22157057+Billy99@users.noreply.github.com>
Billy99
added a commit
to Billy99/ovn-kubernetes-1
that referenced
this pull request
Jul 27, 2020
ebay/libovsdb had the following issue that was fixed upstream: Allow libovsdb to connnect to ovsdb instance over IPv6 connection. (ovn-org#20) When trying to connect to an ovsdb instance via IPv6, encountered an IPv6 parsing issue. In the logic to strip off the leading protocol (i.e. tcp:...), the code uses strings.Split(endpoint, ":"), which does not take into account the ':' in an IPv6 address. Signed-off-by: Billy McFall <22157057+Billy99@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace del statement with pop method, in order to avoid watcher
failures due to KeyError when deleting a pod.
There is at least one corner case where a pod is never processed
and therefore never stored in cache, and that would be when the
kube scheduler is down and does not come up before the pod is deleted.
It is worth noting however that the observed failure is not
critical as the watcher is restarted.
Signed-off-by: Salvatore Orlando salv.orlando@gmail.com