-
Notifications
You must be signed in to change notification settings - Fork 338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not assume pod is always in cache on delete #20
Conversation
Do we need similar changes for _update_service_cache in ovn_k8s/watcher/service_watcher.py and ovn_k8s/modes/overlay.py |
I did not do the change there because I did not find any case where it would fail - for the pod case I verified the watcher fails when the scheduler is down and a pod is deleted. Anyway, we can do that - just to err on the safe side. |
Please go ahead and update the PR. |
Replace del statement with pop method, in order to avoid watcher failures due to KeyError when deleting a pod. There is at least one corner case where a pod is never processed and therefore never stored in cache, and that would be when the kube scheduler is down and does not come up before the pod is deleted. It is worth noting however that the observed failure is not critical as the watcher is restarted. Signed-off-by: Salvatore Orlando <salv.orlando@gmail.com>
33c37a5
to
06a8017
Compare
LGTM. |
Do not install arch-specific dependencies
ebay/libovsdb had the following issue that was fixed upstream: Allow libovsdb to connnect to ovsdb instance over IPv6 connection. (ovn-org#20) When trying to connect to an ovsdb instance via IPv6, encountered an IPv6 parsing issue. In the logic to strip off the leading protocol (i.e. tcp:...), the code uses strings.Split(endpoint, ":"), which does not take into account the ':' in an IPv6 address. Signed-off-by: Billy McFall <22157057+Billy99@users.noreply.github.com>
ebay/libovsdb had the following issue that was fixed upstream: Allow libovsdb to connnect to ovsdb instance over IPv6 connection. (ovn-org#20) When trying to connect to an ovsdb instance via IPv6, encountered an IPv6 parsing issue. In the logic to strip off the leading protocol (i.e. tcp:...), the code uses strings.Split(endpoint, ":"), which does not take into account the ':' in an IPv6 address. Signed-off-by: Billy McFall <22157057+Billy99@users.noreply.github.com>
ebay/libovsdb had the following issue that was fixed upstream: Allow libovsdb to connnect to ovsdb instance over IPv6 connection. (ovn-org#20) When trying to connect to an ovsdb instance via IPv6, encountered an IPv6 parsing issue. In the logic to strip off the leading protocol (i.e. tcp:...), the code uses strings.Split(endpoint, ":"), which does not take into account the ':' in an IPv6 address. Signed-off-by: Billy McFall <22157057+Billy99@users.noreply.github.com>
ebay/libovsdb had the following issue that was fixed upstream: Allow libovsdb to connnect to ovsdb instance over IPv6 connection. (ovn-org#20) When trying to connect to an ovsdb instance via IPv6, encountered an IPv6 parsing issue. In the logic to strip off the leading protocol (i.e. tcp:...), the code uses strings.Split(endpoint, ":"), which does not take into account the ':' in an IPv6 address. Signed-off-by: Billy McFall <22157057+Billy99@users.noreply.github.com>
ebay/libovsdb had the following issue that was fixed upstream: Allow libovsdb to connnect to ovsdb instance over IPv6 connection. (ovn-org#20) When trying to connect to an ovsdb instance via IPv6, encountered an IPv6 parsing issue. In the logic to strip off the leading protocol (i.e. tcp:...), the code uses strings.Split(endpoint, ":"), which does not take into account the ':' in an IPv6 address. Signed-off-by: Billy McFall <22157057+Billy99@users.noreply.github.com>
ebay/libovsdb had the following issue that was fixed upstream: Allow libovsdb to connnect to ovsdb instance over IPv6 connection. (ovn-org#20) When trying to connect to an ovsdb instance via IPv6, encountered an IPv6 parsing issue. In the logic to strip off the leading protocol (i.e. tcp:...), the code uses strings.Split(endpoint, ":"), which does not take into account the ':' in an IPv6 address. Signed-off-by: Billy McFall <22157057+Billy99@users.noreply.github.com>
ebay/libovsdb had the following issue that was fixed upstream: Allow libovsdb to connnect to ovsdb instance over IPv6 connection. (ovn-org#20) When trying to connect to an ovsdb instance via IPv6, encountered an IPv6 parsing issue. In the logic to strip off the leading protocol (i.e. tcp:...), the code uses strings.Split(endpoint, ":"), which does not take into account the ':' in an IPv6 address. Signed-off-by: Billy McFall <22157057+Billy99@users.noreply.github.com>
ebay/libovsdb had the following issue that was fixed upstream: Allow libovsdb to connnect to ovsdb instance over IPv6 connection. (ovn-org#20) When trying to connect to an ovsdb instance via IPv6, encountered an IPv6 parsing issue. In the logic to strip off the leading protocol (i.e. tcp:...), the code uses strings.Split(endpoint, ":"), which does not take into account the ':' in an IPv6 address. Signed-off-by: Billy McFall <22157057+Billy99@users.noreply.github.com>
ebay/libovsdb had the following issue that was fixed upstream: Allow libovsdb to connnect to ovsdb instance over IPv6 connection. (ovn-org#20) When trying to connect to an ovsdb instance via IPv6, encountered an IPv6 parsing issue. In the logic to strip off the leading protocol (i.e. tcp:...), the code uses strings.Split(endpoint, ":"), which does not take into account the ':' in an IPv6 address. Signed-off-by: Billy McFall <22157057+Billy99@users.noreply.github.com>
ebay/libovsdb had the following issue that was fixed upstream: Allow libovsdb to connnect to ovsdb instance over IPv6 connection. (ovn-org#20) When trying to connect to an ovsdb instance via IPv6, encountered an IPv6 parsing issue. In the logic to strip off the leading protocol (i.e. tcp:...), the code uses strings.Split(endpoint, ":"), which does not take into account the ':' in an IPv6 address. Signed-off-by: Billy McFall <22157057+Billy99@users.noreply.github.com>
ebay/libovsdb had the following issue that was fixed upstream: Allow libovsdb to connnect to ovsdb instance over IPv6 connection. (ovn-org#20) When trying to connect to an ovsdb instance via IPv6, encountered an IPv6 parsing issue. In the logic to strip off the leading protocol (i.e. tcp:...), the code uses strings.Split(endpoint, ":"), which does not take into account the ':' in an IPv6 address. Signed-off-by: Billy McFall <22157057+Billy99@users.noreply.github.com>
ebay/libovsdb had the following issue that was fixed upstream: Allow libovsdb to connnect to ovsdb instance over IPv6 connection. (ovn-org#20) When trying to connect to an ovsdb instance via IPv6, encountered an IPv6 parsing issue. In the logic to strip off the leading protocol (i.e. tcp:...), the code uses strings.Split(endpoint, ":"), which does not take into account the ':' in an IPv6 address. Signed-off-by: Billy McFall <22157057+Billy99@users.noreply.github.com>
ebay/libovsdb had the following issue that was fixed upstream: Allow libovsdb to connnect to ovsdb instance over IPv6 connection. (ovn-org#20) When trying to connect to an ovsdb instance via IPv6, encountered an IPv6 parsing issue. In the logic to strip off the leading protocol (i.e. tcp:...), the code uses strings.Split(endpoint, ":"), which does not take into account the ':' in an IPv6 address. Signed-off-by: Billy McFall <22157057+Billy99@users.noreply.github.com>
ebay/libovsdb had the following issue that was fixed upstream: Allow libovsdb to connnect to ovsdb instance over IPv6 connection. (ovn-org#20) When trying to connect to an ovsdb instance via IPv6, encountered an IPv6 parsing issue. In the logic to strip off the leading protocol (i.e. tcp:...), the code uses strings.Split(endpoint, ":"), which does not take into account the ':' in an IPv6 address. Signed-off-by: Billy McFall <22157057+Billy99@users.noreply.github.com>
ebay/libovsdb had the following issue that was fixed upstream: Allow libovsdb to connnect to ovsdb instance over IPv6 connection. (ovn-org#20) When trying to connect to an ovsdb instance via IPv6, encountered an IPv6 parsing issue. In the logic to strip off the leading protocol (i.e. tcp:...), the code uses strings.Split(endpoint, ":"), which does not take into account the ':' in an IPv6 address. Signed-off-by: Billy McFall <22157057+Billy99@users.noreply.github.com>
ebay/libovsdb had the following issue that was fixed upstream: Allow libovsdb to connnect to ovsdb instance over IPv6 connection. (ovn-org#20) When trying to connect to an ovsdb instance via IPv6, encountered an IPv6 parsing issue. In the logic to strip off the leading protocol (i.e. tcp:...), the code uses strings.Split(endpoint, ":"), which does not take into account the ':' in an IPv6 address. Signed-off-by: Billy McFall <22157057+Billy99@users.noreply.github.com>
ebay/libovsdb had the following issue that was fixed upstream: Allow libovsdb to connnect to ovsdb instance over IPv6 connection. (ovn-org#20) When trying to connect to an ovsdb instance via IPv6, encountered an IPv6 parsing issue. In the logic to strip off the leading protocol (i.e. tcp:...), the code uses strings.Split(endpoint, ":"), which does not take into account the ':' in an IPv6 address. Signed-off-by: Billy McFall <22157057+Billy99@users.noreply.github.com>
Replace del statement with pop method, in order to avoid watcher
failures due to KeyError when deleting a pod.
There is at least one corner case where a pod is never processed
and therefore never stored in cache, and that would be when the
kube scheduler is down and does not come up before the pod is deleted.
It is worth noting however that the observed failure is not
critical as the watcher is restarted.
Signed-off-by: Salvatore Orlando salv.orlando@gmail.com