Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kind: Support local registry at "--deploy" #3451

Merged
merged 1 commit into from
Mar 10, 2023

Conversation

qinqon
Copy link
Contributor

@qinqon qinqon commented Feb 28, 2023

- What this PR does and why is it needed
This allow to use kind.sh and --deploy with kind local registry.

- Description for the changelog
kind: Support local registry at "--deploy"

contrib/kind.sh Outdated Show resolved Hide resolved
contrib/kind.sh Outdated Show resolved Hide resolved
contrib/kind.sh Outdated Show resolved Hide resolved
contrib/kind.sh Outdated Show resolved Hide resolved
@qinqon qinqon force-pushed the deploy-and-local-registry branch from 81c6040 to f318b12 Compare March 1, 2023 09:24
Copy link
Contributor

@maiqueb maiqueb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just a couple of nits.

Would you mind also adding info to docs/kind.md explaining how to use this ?

contrib/kind.sh Outdated Show resolved Hide resolved
contrib/kind.sh Outdated Show resolved Hide resolved
@qinqon qinqon force-pushed the deploy-and-local-registry branch 3 times, most recently from 0306135 to a5c09a5 Compare March 1, 2023 12:50
@qinqon qinqon requested a review from maiqueb March 1, 2023 12:51
Copy link
Contributor

@maiqueb maiqueb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve on the conceptual level but I would like to see the kind.md docs improved by explaining how to use this from the dev perspective i.e. push to the local registry, force the rollout of the new daemonset pods, etc.

@qinqon qinqon force-pushed the deploy-and-local-registry branch 3 times, most recently from 90d7d71 to cf9cae8 Compare March 8, 2023 09:52
docs/kind.md Outdated Show resolved Hide resolved
@qinqon qinqon force-pushed the deploy-and-local-registry branch from cf9cae8 to 106ad49 Compare March 8, 2023 10:03
docs/kind.md Outdated Show resolved Hide resolved
@qinqon qinqon force-pushed the deploy-and-local-registry branch from 106ad49 to 6519246 Compare March 8, 2023 10:31
@qinqon qinqon requested a review from maiqueb March 8, 2023 10:33
@qinqon
Copy link
Contributor Author

qinqon commented Mar 8, 2023

/cc @trozet

docs/kind.md Outdated Show resolved Hide resolved
docs/kind.md Outdated Show resolved Hide resolved
docs/kind.md Outdated Show resolved Hide resolved
docs/kind.md Outdated Show resolved Hide resolved
contrib/kind.sh Outdated Show resolved Hide resolved
contrib/kind.sh Show resolved Hide resolved
contrib/kind.sh Show resolved Hide resolved
docs/kind.md Outdated Show resolved Hide resolved
docs/kind.md Outdated Show resolved Hide resolved
contrib/kind.sh Show resolved Hide resolved
@qinqon qinqon requested review from jcaamano and removed request for maiqueb March 10, 2023 07:21
This allow to use kind.sh and `--deploy` with kind local registry.

Signed-off-by: Enrique Llorente <ellorent@redhat.com>
@jcaamano jcaamano merged commit 052010e into ovn-org:master Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants