-
Notifications
You must be signed in to change notification settings - Fork 338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kind: Support local registry at "--deploy" #3451
Conversation
63bb8e0
to
81c6040
Compare
81c6040
to
f318b12
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, just a couple of nits.
Would you mind also adding info to docs/kind.md
explaining how to use this ?
0306135
to
a5c09a5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approve on the conceptual level but I would like to see the kind.md docs improved by explaining how to use this from the dev perspective i.e. push to the local registry, force the rollout of the new daemonset pods, etc.
90d7d71
to
cf9cae8
Compare
cf9cae8
to
106ad49
Compare
106ad49
to
6519246
Compare
/cc @trozet |
6519246
to
7ce9b61
Compare
This allow to use kind.sh and `--deploy` with kind local registry. Signed-off-by: Enrique Llorente <ellorent@redhat.com>
7ce9b61
to
41b4393
Compare
- What this PR does and why is it needed
This allow to use kind.sh and
--deploy
with kind local registry.- Description for the changelog
kind: Support local registry at "--deploy"